[DiscordArchive] what id did you give the node and what name does that node have in that dbc? additionally, is there
[DiscordArchive] what id did you give the node and what name does that node have in that dbc? additionally, is there
Original source
Ah, I thought it might not have worked, I analysed the code before attempting to apply the diffs and noticed each line was completely different to the red ones in the diff. lol
rektbyfaith
03-23-2022, 07:44 PM #51Archived author: helenah1734 • Posted: 2022-03-23T19:44:33.524000+00:00
Original source
Ah, I thought it might not have worked, I analysed the code before attempting to apply the diffs and noticed each line was completely different to the red ones in the diff. lol
Original source
you cannot just clone our version of trinitycore entirely, it's specifically made to work within the larger tswow framework
rektbyfaith
03-23-2022, 07:44 PM #52Archived author: <o> • Posted: 2022-03-23T19:44:49.073000+00:00
Original source
you cannot just clone our version of trinitycore entirely, it's specifically made to work within the larger tswow framework
Original source
but those fixes would apply to any recent trinitycore version
rektbyfaith
03-23-2022, 07:45 PM #53Archived author: <o> • Posted: 2022-03-23T19:45:03.136000+00:00
Original source
but those fixes would apply to any recent trinitycore version
Original source
Okay I'll erm... cancel the compilation.
rektbyfaith
03-23-2022, 07:45 PM #54Archived author: helenah1734 • Posted: 2022-03-23T19:45:39.600000+00:00
Original source
Okay I'll erm... cancel the compilation.
Original source
Thanks
rektbyfaith
03-23-2022, 07:45 PM #55Archived author: helenah1734 • Posted: 2022-03-23T19:45:40.844000+00:00
Original source
Thanks
Original source
<@!787614711738138634> Seems as you merged only a few days ago and I think my core is older then I'm going to grab the latest TrinityCore as patching the current source I have is causing rejects.
rektbyfaith
03-23-2022, 08:07 PM #56Archived author: helenah1734 • Posted: 2022-03-23T20:07:56.711000+00:00
Original source
<@!787614711738138634> Seems as you merged only a few days ago and I think my core is older then I'm going to grab the latest TrinityCore as patching the current source I have is causing rejects.
Original source
```--- src/server/game/Globals/ObjectMgr.cpp
+++ src/server/game/Globals/ObjectMgr.cpp
@@ -6834,7 +6836,7 @@ uint32 ObjectMgr::GetNearestTaxiNode(float x, float y, float z, uint32 mapid, ui
// skip not taxi network nodes
// @tswow-begin taxi nodes bounds
- if (field < sTaxiNodesMask.size() && (sTaxiNodesMask[field] & submask) == 0)
+ if (field >= sTaxiNodesMask.size() || (sTaxiNodesMask[field] & submask) == 0)
// @tswow-end
continue;```
rektbyfaith
03-23-2022, 08:11 PM #57Archived author: helenah1734 • Posted: 2022-03-23T20:11:13.374000+00:00
Original source
```--- src/server/game/Globals/ObjectMgr.cpp
+++ src/server/game/Globals/ObjectMgr.cpp
@@ -6834,7 +6836,7 @@ uint32 ObjectMgr::GetNearestTaxiNode(float x, float y, float z, uint32 mapid, ui
// skip not taxi network nodes
// @tswow-begin taxi nodes bounds
- if (field < sTaxiNodesMask.size() && (sTaxiNodesMask[field] & submask) == 0)
+ if (field >= sTaxiNodesMask.size() || (sTaxiNodesMask[field] & submask) == 0)
// @tswow-end
continue;```
Original source
Yeah at the minus line there is no data.
rektbyfaith
03-23-2022, 08:13 PM #58Archived author: helenah1734 • Posted: 2022-03-23T20:13:26.611000+00:00
Original source
Yeah at the minus line there is no data.
Original source
Seems that
```if (field < sTaxiNodesMask.size() && (sTaxiNodesMask[field] & submask) == 0)```
has been changed to
```if ((sTaxiNodesMask[field] & submask) == 0)```
but it looks easy to merge in what you did.
rektbyfaith
03-23-2022, 08:20 PM #59Archived author: helenah1734 • Posted: 2022-03-23T20:20:13.346000+00:00
Original source
Seems that
```if (field < sTaxiNodesMask.size() && (sTaxiNodesMask[field] & submask) == 0)```
has been changed to
```if ((sTaxiNodesMask[field] & submask) == 0)```
but it looks easy to merge in what you did.
Original source
Okay going to compile now.
rektbyfaith
03-23-2022, 08:26 PM #60Archived author: helenah1734 • Posted: 2022-03-23T20:26:55.552000+00:00
Original source
Okay going to compile now.
1 Guest(s)
1 Guest(s)