Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] we're to assume that MinDuration being > 0 should prevail over Speed > 0.0f?

[DiscordArchive] we're to assume that MinDuration being > 0 should prevail over Speed > 0.0f?

[DiscordArchive] we're to assume that MinDuration being > 0 should prevail over Speed > 0.0f?

Pages (3): Previous 1 2 3 Next
rektbyfaith
Administrator
0
05-06-2025, 05:01 PM
#11
Archived author: Tea • Posted: 2025-05-06T17:01:57.523000+00:00
Original source

```
5111862
myguid
uint16 0
uint16 0
itspos
uint32 154445
float 100
uint16 0
uint16 0
uint16 0
float 0
float 3
uint8 0
```
rektbyfaith
05-06-2025, 05:01 PM #11

Archived author: Tea • Posted: 2025-05-06T17:01:57.523000+00:00
Original source

```
5111862
myguid
uint16 0
uint16 0
itspos
uint32 154445
float 100
uint16 0
uint16 0
uint16 0
float 0
float 3
uint8 0
```

rektbyfaith
Administrator
0
05-06-2025, 05:02 PM
#12
Archived author: Tea • Posted: 2025-05-06T17:02:17.262000+00:00
Original source

then target something and use `.debug send op`
rektbyfaith
05-06-2025, 05:02 PM #12

Archived author: Tea • Posted: 2025-05-06T17:02:17.262000+00:00
Original source

then target something and use `.debug send op`

rektbyfaith
Administrator
0
05-06-2025, 05:02 PM
#13
Archived author: Tea • Posted: 2025-05-06T17:02:36.663000+00:00
Original source

thats going to force SMSG_PLAY_SPELL_VISUAL
rektbyfaith
05-06-2025, 05:02 PM #13

Archived author: Tea • Posted: 2025-05-06T17:02:36.663000+00:00
Original source

thats going to force SMSG_PLAY_SPELL_VISUAL

rektbyfaith
Administrator
0
05-06-2025, 05:02 PM
#14
Archived author: Tea • Posted: 2025-05-06T17:02:54.531000+00:00
Original source

then replace the 3 in second to last row with 0
rektbyfaith
05-06-2025, 05:02 PM #14

Archived author: Tea • Posted: 2025-05-06T17:02:54.531000+00:00
Original source

then replace the 3 in second to last row with 0

rektbyfaith
Administrator
0
05-06-2025, 05:03 PM
#15
Archived author: Telegrill • Posted: 2025-05-06T17:03:28.677000+00:00
Original source

it would override the min duration of the visual?
rektbyfaith
05-06-2025, 05:03 PM #15

Archived author: Telegrill • Posted: 2025-05-06T17:03:28.677000+00:00
Original source

it would override the min duration of the visual?

rektbyfaith
Administrator
0
05-06-2025, 05:03 PM
#16
Archived author: Tea • Posted: 2025-05-06T17:03:44.991000+00:00
Original source

yes
rektbyfaith
05-06-2025, 05:03 PM #16

Archived author: Tea • Posted: 2025-05-06T17:03:44.991000+00:00
Original source

yes

rektbyfaith
Administrator
0
05-06-2025, 05:04 PM
#17
Archived author: Telegrill • Posted: 2025-05-06T17:04:03.772000+00:00
Original source

I see
rektbyfaith
05-06-2025, 05:04 PM #17

Archived author: Telegrill • Posted: 2025-05-06T17:04:03.772000+00:00
Original source

I see

rektbyfaith
Administrator
0
05-06-2025, 05:09 PM
#18
Archived author: Telegrill • Posted: 2025-05-06T17:09:15.051000+00:00
Original source

```cpp
else if (m_spellInfo->Speed > 0.0f)
{
// We should not subtract caster size from dist calculation (fixes execution time desync with animation on client, eg. Malleable Goo cast by PP)
float dist = m_caster->GetExactDist(*m_targets.GetDstPos());
float travelTime = dist / m_spellInfo->Speed;

float totalTime = travelTime + launchDelay;

if (float minDuration = m_spellInfo->GetMinDuration(); minDuration > 0.0f)
totalTime = std::max(totalTime, minDuration);

return uint64(std::floor(totalTime * 1000.0f));
}
```
rektbyfaith
05-06-2025, 05:09 PM #18

Archived author: Telegrill • Posted: 2025-05-06T17:09:15.051000+00:00
Original source

```cpp
else if (m_spellInfo->Speed > 0.0f)
{
// We should not subtract caster size from dist calculation (fixes execution time desync with animation on client, eg. Malleable Goo cast by PP)
float dist = m_caster->GetExactDist(*m_targets.GetDstPos());
float travelTime = dist / m_spellInfo->Speed;

float totalTime = travelTime + launchDelay;

if (float minDuration = m_spellInfo->GetMinDuration(); minDuration > 0.0f)
totalTime = std::max(totalTime, minDuration);

return uint64(std::floor(totalTime * 1000.0f));
}
```

rektbyfaith
Administrator
0
05-06-2025, 05:09 PM
#19
Archived author: Telegrill • Posted: 2025-05-06T17:09:22.410000+00:00
Original source

oops so basically this should do
rektbyfaith
05-06-2025, 05:09 PM #19

Archived author: Telegrill • Posted: 2025-05-06T17:09:22.410000+00:00
Original source

oops so basically this should do

rektbyfaith
Administrator
0
05-06-2025, 05:10 PM
#20
Archived author: Telegrill • Posted: 2025-05-06T17:10:16.156000+00:00
Original source

with a new Getter impl, unless you'd rather use the field directly
rektbyfaith
05-06-2025, 05:10 PM #20

Archived author: Telegrill • Posted: 2025-05-06T17:10:16.156000+00:00
Original source

with a new Getter impl, unless you'd rather use the field directly

Pages (3): Previous 1 2 3 Next
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)