Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] What's the difference between the - and regular versions of a spell in the spell_proc table?

[DiscordArchive] What's the difference between the - and regular versions of a spell in the spell_proc table?

[DiscordArchive] What's the difference between the - and regular versions of a spell in the spell_proc table?

Pages (6): Previous 1 2 3 4 5 6 Next
rektbyfaith
Administrator
0
08-04-2025, 03:16 PM
#21
Archived author: jackpoz • Posted: 2025-08-04T15:16:04.428000+00:00
Original source

But not so indefinitely
rektbyfaith
08-04-2025, 03:16 PM #21

Archived author: jackpoz • Posted: 2025-08-04T15:16:04.428000+00:00
Original source

But not so indefinitely

rektbyfaith
Administrator
0
08-04-2025, 03:16 PM
#22
Archived author: Takenbacon • Posted: 2025-08-04T15:16:13.210000+00:00
Original source

could swear deadlock retries have existed since...forever in this codebase
rektbyfaith
08-04-2025, 03:16 PM #22

Archived author: Takenbacon • Posted: 2025-08-04T15:16:13.210000+00:00
Original source

could swear deadlock retries have existed since...forever in this codebase

rektbyfaith
Administrator
0
08-04-2025, 03:16 PM
#23
Archived author: jackpoz • Posted: 2025-08-04T15:16:21.467000+00:00
Original source

Nope
rektbyfaith
08-04-2025, 03:16 PM #23

Archived author: jackpoz • Posted: 2025-08-04T15:16:21.467000+00:00
Original source

Nope

rektbyfaith
Administrator
0
08-04-2025, 03:17 PM
#24
Archived author: jackpoz • Posted: 2025-08-04T15:17:13.971000+00:00
Original source

https://github.com/TrinityCore/TrinityCo...a48e6ff259
[Embed: Shared/Database: Fix transactions not being recommitted on dead-loc...]
…error

Fix transactions not being recommitted on dead-lock error (error code 1213) because of calling http://dev.mysql.com/doc/refman/5.0/en/mysql-errno.html after sending the ROLLBACK command. Th...
https://github.com/TrinityCore/TrinityCo...a48e6ff259
rektbyfaith
08-04-2025, 03:17 PM #24

Archived author: jackpoz • Posted: 2025-08-04T15:17:13.971000+00:00
Original source

https://github.com/TrinityCore/TrinityCo...a48e6ff259
[Embed: Shared/Database: Fix transactions not being recommitted on dead-loc...]
…error

Fix transactions not being recommitted on dead-lock error (error code 1213) because of calling http://dev.mysql.com/doc/refman/5.0/en/mysql-errno.html after sending the ROLLBACK command. Th...
https://github.com/TrinityCore/TrinityCo...a48e6ff259

rektbyfaith
Administrator
0
08-04-2025, 03:17 PM
#25
Archived author: jackpoz • Posted: 2025-08-04T15:17:31.794000+00:00
Original source

Or more like, the code that was there before my fix wasn't working
rektbyfaith
08-04-2025, 03:17 PM #25

Archived author: jackpoz • Posted: 2025-08-04T15:17:31.794000+00:00
Original source

Or more like, the code that was there before my fix wasn't working

rektbyfaith
Administrator
0
08-04-2025, 03:18 PM
#26
Archived author: jackpoz • Posted: 2025-08-04T15:18:40.877000+00:00
Original source

It tried to check for errors but the error code was about the ROLLBACK command in the transaction, not the command that caused the error
rektbyfaith
08-04-2025, 03:18 PM #26

Archived author: jackpoz • Posted: 2025-08-04T15:18:40.877000+00:00
Original source

It tried to check for errors but the error code was about the ROLLBACK command in the transaction, not the command that caused the error

rektbyfaith
Administrator
0
08-04-2025, 03:19 PM
#27
Archived author: jackpoz • Posted: 2025-08-04T15:19:15.058000+00:00
Original source

I often wondered how few devs ever debugged their code with breakpoints and F10/F11
rektbyfaith
08-04-2025, 03:19 PM #27

Archived author: jackpoz • Posted: 2025-08-04T15:19:15.058000+00:00
Original source

I often wondered how few devs ever debugged their code with breakpoints and F10/F11

rektbyfaith
Administrator
0
08-04-2025, 03:20 PM
#28
Archived author: Tea • Posted: 2025-08-04T15:20:03.361000+00:00
Original source

by testing the success path, obviously
rektbyfaith
08-04-2025, 03:20 PM #28

Archived author: Tea • Posted: 2025-08-04T15:20:03.361000+00:00
Original source

by testing the success path, obviously

rektbyfaith
Administrator
0
08-04-2025, 03:20 PM
#29
Archived author: jackpoz • Posted: 2025-08-04T15:20:19.254000+00:00
Original source

https://github.com/TrinityCore/TrinityCo...67b1b0a069 also made retrying a bit more meaningful
[Embed: Shared/Database: Improve dead-lock error handling · TrinityCore/Tr...]
Improve dead-lock error handling by making sure only 1 thread at time retries to execute a transaction so they don't keep dead-locking each other.
https://github.com/TrinityCore/TrinityCo...67b1b0a069
rektbyfaith
08-04-2025, 03:20 PM #29

Archived author: jackpoz • Posted: 2025-08-04T15:20:19.254000+00:00
Original source

https://github.com/TrinityCore/TrinityCo...67b1b0a069 also made retrying a bit more meaningful
[Embed: Shared/Database: Improve dead-lock error handling · TrinityCore/Tr...]
Improve dead-lock error handling by making sure only 1 thread at time retries to execute a transaction so they don't keep dead-locking each other.
https://github.com/TrinityCore/TrinityCo...67b1b0a069

rektbyfaith
Administrator
0
08-04-2025, 03:20 PM
#30
Archived author: jackpoz • Posted: 2025-08-04T15:20:40.980000+00:00
Original source

No point having 10 threads deadlocking and retrying all at the same time
rektbyfaith
08-04-2025, 03:20 PM #30

Archived author: jackpoz • Posted: 2025-08-04T15:20:40.980000+00:00
Original source

No point having 10 threads deadlocking and retrying all at the same time

Pages (6): Previous 1 2 3 4 5 6 Next
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)