[DiscordArchive] btw, why is the time zone default set for ENV TZ=Etc/UTC? Didn't Docker create a container with the
[DiscordArchive] btw, why is the time zone default set for ENV TZ=Etc/UTC? Didn't Docker create a container with the
Original source
btw, why is the time zone default set for ENV TZ=Etc/UTC? Didn't Docker create a container with the timezone of the host machine?
rektbyfaith
08-06-2023, 11:13 AM #1Archived author: podmepodme • Posted: 2023-08-06T11:13:02.452000+00:00
Original source
btw, why is the time zone default set for ENV TZ=Etc/UTC? Didn't Docker create a container with the timezone of the host machine?
Original source
Which i think make more sense, i can make PR for removal.
rektbyfaith
08-06-2023, 11:18 AM #2Archived author: podmepodme • Posted: 2023-08-06T11:18:22.857000+00:00
Original source
Which i think make more sense, i can make PR for removal.
Original source
https://github.com/caiorss/sample-cpp-plugin
Something like this would be ideal to build the modules off of, instead of the way they are built into the binary right now
[Embed: GitHub - caiorss/sample-cpp-plugin: C++ cross-platform plugin archi...]
C++ cross-platform plugin architechture demonstration - GitHub - caiorss/sample-cpp-plugin: C++ cross-platform plugin architechture demonstration
https://github.com/caiorss/sample-cpp-plugin
rektbyfaith
08-06-2023, 11:26 AM #3Archived author: Foe • Posted: 2023-08-06T11:26:43.794000+00:00
Original source
https://github.com/caiorss/sample-cpp-plugin
Something like this would be ideal to build the modules off of, instead of the way they are built into the binary right now
[Embed: GitHub - caiorss/sample-cpp-plugin: C++ cross-platform plugin archi...]
C++ cross-platform plugin architechture demonstration - GitHub - caiorss/sample-cpp-plugin: C++ cross-platform plugin architechture demonstration
https://github.com/caiorss/sample-cpp-plugin
Original source
Would also allow for plug and play of modules without needing to recompile
rektbyfaith
08-06-2023, 11:27 AM #4Archived author: Foe • Posted: 2023-08-06T11:27:03.569000+00:00
Original source
Would also allow for plug and play of modules without needing to recompile
Original source
There is acore-docker for that with a pre-compiled image.
rektbyfaith
08-06-2023, 11:34 AM #5Archived author: Honey • Posted: 2023-08-06T11:34:54.713000+00:00
Original source
There is acore-docker for that with a pre-compiled image.
Original source
I think it comes with mod-transmog and mod-eluna.
rektbyfaith
08-06-2023, 11:35 AM #6Archived author: Honey • Posted: 2023-08-06T11:35:45.431000+00:00
Original source
I think it comes with mod-transmog and mod-eluna.
Original source
Definitely much better, but ideally shouldn't be with any modules at all and with a revised and properly implemented external library interface for modules
rektbyfaith
08-06-2023, 11:43 AM #7Archived author: Foe • Posted: 2023-08-06T11:43:11.806000+00:00
Original source
Definitely much better, but ideally shouldn't be with any modules at all and with a revised and properly implemented external library interface for modules
Original source
yes, a million times yes. When I was getting started with the project, the first thing I noticed was how complicated the docker installation was. It was "why do I have to run all these commands?" instead of "OK, I ran `docker compose up -d` and here it goes"
rektbyfaith
08-06-2023, 01:07 PM #8Archived author: mynameismeat • Posted: 2023-08-06T13:07:39.293000+00:00
Original source
yes, a million times yes. When I was getting started with the project, the first thing I noticed was how complicated the docker installation was. It was "why do I have to run all these commands?" instead of "OK, I ran `docker compose up -d` and here it goes"
Original source
modules as pluggable dynamic libraries would be very nice. Theoretically as long as the module hook API doesn't change often, these could have a relatively wide range of support of ACore versions.
I think the pandoras box is opened for acore-docker. It's been created and I guess we support it, and unless we want to completely deprecate it, changes we make with the docker build in azerothcore-wotlk need to be compatible with acore-docker. Maybe the easiest thing would be to split out the "dashboard" collection of shell/typescript scripts and put all of those into acore-docker, as well as the current build process.
rektbyfaith
08-06-2023, 01:16 PM #9Archived author: mynameismeat • Posted: 2023-08-06T13:16:28.778000+00:00
Original source
modules as pluggable dynamic libraries would be very nice. Theoretically as long as the module hook API doesn't change often, these could have a relatively wide range of support of ACore versions.
I think the pandoras box is opened for acore-docker. It's been created and I guess we support it, and unless we want to completely deprecate it, changes we make with the docker build in azerothcore-wotlk need to be compatible with acore-docker. Maybe the easiest thing would be to split out the "dashboard" collection of shell/typescript scripts and put all of those into acore-docker, as well as the current build process.
Original source
Having two separate docker implementation is just silly imo, I'd bank all on acore-docker. Personally I'd also remove everything dev related from the docker implementation, it doesn't really make sense to do development in a non-development environment
rektbyfaith
08-06-2023, 01:34 PM #10Archived author: Foe • Posted: 2023-08-06T13:34:59.321000+00:00
Original source
Having two separate docker implementation is just silly imo, I'd bank all on acore-docker. Personally I'd also remove everything dev related from the docker implementation, it doesn't really make sense to do development in a non-development environment