[DiscordArchive] btw, why is the time zone default set for ENV TZ=Etc/UTC? Didn't Docker create a container with the
[DiscordArchive] btw, why is the time zone default set for ENV TZ=Etc/UTC? Didn't Docker create a container with the
Original source
Or at least separate images
rektbyfaith
08-06-2023, 01:37 PM #11Archived author: Foe • Posted: 2023-08-06T13:37:40.012000+00:00
Original source
Or at least separate images
Original source
That actually kinda brings up another thought. I wonder if some of the cruft in the Dockerfile/build process is there because it may have been written before Docker had better caching features.
Nowadays docker just has really good file-based caching inside of the build so it's just really easy to get the same iteration speed as you would with a native build
rektbyfaith
08-06-2023, 01:39 PM #12Archived author: mynameismeat • Posted: 2023-08-06T13:39:52.014000+00:00
Original source
That actually kinda brings up another thought. I wonder if some of the cruft in the Dockerfile/build process is there because it may have been written before Docker had better caching features.
Nowadays docker just has really good file-based caching inside of the build so it's just really easy to get the same iteration speed as you would with a native build
Original source
Probably
rektbyfaith
08-06-2023, 01:41 PM #13Archived author: Foe • Posted: 2023-08-06T13:41:21.026000+00:00
Original source
Probably
Original source
I think keeping a basic set of files in the .devcontainers folder, specifically for devcontainers is harmless, but it should be wholly split out/removed from the main docker build of the repo/project (As in, all isolated to the .devcontainers folder)
rektbyfaith
08-06-2023, 01:51 PM #14Archived author: mynameismeat • Posted: 2023-08-06T13:51:00.161000+00:00
Original source
I think keeping a basic set of files in the .devcontainers folder, specifically for devcontainers is harmless, but it should be wholly split out/removed from the main docker build of the repo/project (As in, all isolated to the .devcontainers folder)
Original source
At the absolute maximum to understand the Docker build, someone should only need to open 2 files.
The current documentation for the docker build has the user run `./acore.sh docker build`. What does that do?
1. Oh, it sources `apps/installer/main.sh`
2. Oh, that file also sources `apps/installer/includes/includes.sh`
a. That file sources `apps/bash_shared/includes.sh`
b. That file sources 4 more files, including installing a JavaScript runtime??? (and theres no choice otherwise or to use a system version)
c. If you're on MacOS it installs homebrew (i imagine most people would have this installed already but it's just a bit weird to do this)
c. All of these `source` calls are setting up new environment variables that are apparently needed in some way (if they weren't why add them)
3. This then drops into a Typescript file?
4. That Typescript file is just executing shell commands? what the fuck?
a. The shell commands are just docker commands
rektbyfaith
08-06-2023, 01:51 PM #15Archived author: mynameismeat • Posted: 2023-08-06T13:51:01.244000+00:00
Original source
At the absolute maximum to understand the Docker build, someone should only need to open 2 files.
The current documentation for the docker build has the user run `./acore.sh docker build`. What does that do?
1. Oh, it sources `apps/installer/main.sh`
2. Oh, that file also sources `apps/installer/includes/includes.sh`
a. That file sources `apps/bash_shared/includes.sh`
b. That file sources 4 more files, including installing a JavaScript runtime??? (and theres no choice otherwise or to use a system version)
c. If you're on MacOS it installs homebrew (i imagine most people would have this installed already but it's just a bit weird to do this)
c. All of these `source` calls are setting up new environment variables that are apparently needed in some way (if they weren't why add them)
3. This then drops into a Typescript file?
4. That Typescript file is just executing shell commands? what the fuck?
a. The shell commands are just docker commands
Original source
It just made me feel like "so whats wrong with running `docker compose up -d`.
rektbyfaith
08-06-2023, 01:51 PM #16Archived author: mynameismeat • Posted: 2023-08-06T13:51:23.921000+00:00
Original source
It just made me feel like "so whats wrong with running `docker compose up -d`.
Original source
Oh cool that only starts the database. Then begins "docker compose has profiles?"
rektbyfaith
08-06-2023, 01:51 PM #17Archived author: mynameismeat • Posted: 2023-08-06T13:51:30.754000+00:00
Original source
Oh cool that only starts the database. Then begins "docker compose has profiles?"
Original source
Yeah, I don't like the design at all
rektbyfaith
08-06-2023, 02:09 PM #18Archived author: Foe • Posted: 2023-08-06T14:09:40.677000+00:00
Original source
Yeah, I don't like the design at all
1 Guest(s)
1 Guest(s)