[DiscordArchive] isn't that because the binaries are generated by a separate build container and it needs to get them
[DiscordArchive] isn't that because the binaries are generated by a separate build container and it needs to get them
Original source
soooo.... can we just get rid of `env.docker`?
rektbyfaith
05-01-2023, 05:05 PM #41Archived author: KJack • Posted: 2023-05-01T17:05:44.945000+00:00
Original source
soooo.... can we just get rid of `env.docker`?
Original source
or rather, combine them? they have different contents
rektbyfaith
05-01-2023, 05:06 PM #42Archived author: KJack • Posted: 2023-05-01T17:06:22.456000+00:00
Original source
or rather, combine them? they have different contents
Original source
I'm gonna do that, see what the PR people say.
rektbyfaith
05-01-2023, 05:07 PM #43Archived author: KJack • Posted: 2023-05-01T17:07:38.835000+00:00
Original source
I'm gonna do that, see what the PR people say.
Original source
sorry for question overload. do you know if the process that merges `env/docker/etc/worldserver.conf.dockerdist` into `src/server/apps/worldserver/worldserver.conf.dist` supports environment variables?
rektbyfaith
05-01-2023, 05:15 PM #44Archived author: KJack • Posted: 2023-05-01T17:15:33.138000+00:00
Original source
sorry for question overload. do you know if the process that merges `env/docker/etc/worldserver.conf.dockerdist` into `src/server/apps/worldserver/worldserver.conf.dist` supports environment variables?
Original source
I am guessing that's why the DB settings aren't being propagated into those config files.
rektbyfaith
05-01-2023, 05:15 PM #45Archived author: KJack • Posted: 2023-05-01T17:15:48.567000+00:00
Original source
I am guessing that's why the DB settings aren't being propagated into those config files.
Original source
no it doesn't, but it'd be cool to implement that.
it's these 2 functions that do it mainly
https://github.com/azerothcore/azerothco...102-L177C2
https://github.com/azerothcore/azerothco...#L191-L220
rektbyfaith
05-01-2023, 05:17 PM #46Archived author: mynameismeat • Posted: 2023-05-01T17:17:56.374000+00:00
Original source
no it doesn't, but it'd be cool to implement that.
it's these 2 functions that do it mainly
https://github.com/azerothcore/azerothco...102-L177C2
https://github.com/azerothcore/azerothco...#L191-L220
Original source
got it, that makes of lot of sense then. i may work on that separately from this first PR.
rektbyfaith
05-01-2023, 05:18 PM #47Archived author: KJack • Posted: 2023-05-01T17:18:37.914000+00:00
Original source
got it, that makes of lot of sense then. i may work on that separately from this first PR.
Original source
I'd prefer if a lot of the configuration was generated from environment variables in the first place but unfortunately that is easier said than done
rektbyfaith
05-01-2023, 05:18 PM #48Archived author: mynameismeat • Posted: 2023-05-01T17:18:50.121000+00:00
Original source
I'd prefer if a lot of the configuration was generated from environment variables in the first place but unfortunately that is easier said than done
Original source
especially while maintaining a single repo for both docker and straight installs, yeah
rektbyfaith
05-01-2023, 05:19 PM #49Archived author: KJack • Posted: 2023-05-01T17:19:14.480000+00:00
Original source
especially while maintaining a single repo for both docker and straight installs, yeah
Original source
Make sure to ping Yehonal into any docker related PRs. He's the only one to review them iirc.
rektbyfaith
05-01-2023, 05:19 PM #50Archived author: Honey • Posted: 2023-05-01T17:19:33.560000+00:00
Original source
Make sure to ping Yehonal into any docker related PRs. He's the only one to review them iirc.
1 Guest(s)
1 Guest(s)