[DiscordArchive] so anyone knows why the `empty()` check got removed?
[DiscordArchive] so anyone knows why the `empty()` check got removed?
Original source
since it got reverted
rektbyfaith
05-20-2021, 10:06 PM #11Archived author: Roboto • Posted: 2021-05-20T22:06:56.135000+00:00
Original source
since it got reverted
Original source
hold, Master Yehonal is typing!
rektbyfaith
05-20-2021, 10:06 PM #12Archived author: Kitzunu • Posted: 2021-05-20T22:06:58.472000+00:00
Original source
hold, Master Yehonal is typing!
Original source
probably that check should be integrated here directly:
```
[[nodiscard]] bool IsNull() const
{
return data.value == nullptr;
}
```
rektbyfaith
05-20-2021, 10:07 PM #13Archived author: Yehonal • Posted: 2021-05-20T22:07:00.461000+00:00
Original source
probably that check should be integrated here directly:
```
[[nodiscard]] bool IsNull() const
{
return data.value == nullptr;
}
```
Original source
haha
rektbyfaith
05-20-2021, 10:07 PM #14Archived author: Roboto • Posted: 2021-05-20T22:07:01.262000+00:00
Original source
haha
Original source
as <@!175631911450836993> said binary fields are treated differently
rektbyfaith
05-20-2021, 10:08 PM #15Archived author: Yehonal • Posted: 2021-05-20T22:08:06.093000+00:00
Original source
as <@!175631911450836993> said binary fields are treated differently
Original source
We probably shouldnt change IsNull tho as it shouldnt be used for binary then
rektbyfaith
05-20-2021, 10:08 PM #16Archived author: Kitzunu • Posted: 2021-05-20T22:08:38.124000+00:00
Original source
We probably shouldnt change IsNull tho as it shouldnt be used for binary then
Original source
either we could just check empty() or make a function of it
rektbyfaith
05-20-2021, 10:09 PM #17Archived author: Kitzunu • Posted: 2021-05-20T22:09:00.875000+00:00
Original source
either we could just check empty() or make a function of it
Original source
I wouldn't wanna break other stuff that uses it though
rektbyfaith
05-20-2021, 10:09 PM #18Archived author: Roboto • Posted: 2021-05-20T22:09:15.780000+00:00
Original source
I wouldn't wanna break other stuff that uses it though
Original source
it's barely used that's why we did't discovered it before
rektbyfaith
05-20-2021, 10:09 PM #19Archived author: Yehonal • Posted: 2021-05-20T22:09:34.999000+00:00
Original source
it's barely used that's why we did't discovered it before
Original source
Yea, IsNull is also used for game_event TIMESTAMP
rektbyfaith
05-20-2021, 10:09 PM #20Archived author: Kitzunu • Posted: 2021-05-20T22:09:36.719000+00:00
Original source
Yea, IsNull is also used for game_event TIMESTAMP