[DiscordArchive] so anyone knows why the `empty()` check got removed?
[DiscordArchive] so anyone knows why the `empty()` check got removed?
![[Image: unknown.png?ex=690c73f3&is=690b2273&hm=1...7045e801c&]](https://cdn.discordapp.com/attachments/369084351129845760/845060803182592040/unknown.png?ex=690c73f3&is=690b2273&hm=1f30f26697b57f491c4b5984ac5347d66cbc47c4489b199653ed5d77045e801c&)
Archived author: Kitzunu • Posted: 2021-05-20T22:09:56.451000+00:00
Original source
![[Image: unknown.png?ex=690c73f3&is=690b2273&hm=1...7045e801c&]](https://cdn.discordapp.com/attachments/369084351129845760/845060803182592040/unknown.png?ex=690c73f3&is=690b2273&hm=1f30f26697b57f491c4b5984ac5347d66cbc47c4489b199653ed5d77045e801c&)
Archived author: Kitzunu • Posted: 2021-05-20T22:09:58.298000+00:00
Original source
all uses of it
Archived author: Roboto • Posted: 2021-05-20T22:10:11.320000+00:00
Original source
hmm indeed
Archived author: Kitzunu • Posted: 2021-05-20T22:10:29.579000+00:00
Original source
but TIMESTAMP is not binary? So we shouldnt change IsNull imo
Archived author: Kitzunu • Posted: 2021-05-20T22:10:49.119000+00:00
Original source
but instead just go for .value().empty()
Archived author: Kitzunu • Posted: 2021-05-20T22:11:13.839000+00:00
Original source
<@!175631911450836993> have you tested if it works? if so I could just revert the revert and add the changes
Archived author: Roboto • Posted: 2021-05-20T22:11:24.551000+00:00
Original source
yeah yeah it does
Archived author: Roboto • Posted: 2021-05-20T22:11:42.763000+00:00
Original source
https://discord.com/channels/21758927576...5599667260
Archived author: Roboto • Posted: 2021-05-20T22:11:57.080000+00:00
Original source
I did the same thing but with a .size() instead of .empty()
Archived author: Yehonal • Posted: 2021-05-20T22:13:01.970000+00:00
Original source
I'm just wondering if in future someone else uses the same method for the same reason, we will have this problem again