[DiscordArchive] 6969 ?
[DiscordArchive] 6969 ?
Original source
isnt that it though ? consider something like this
```cpp
void OnAfterLootStoreLoaded(LootStore *loot_store)
{
auto items_to_remove;
auto items_to_add;
for (auto table : loot_store) {
// remove item from table
for (auto item_to_remove : items_to_remove) {
if (table.contains(item_to_remove)) {
table.erase(item_to_remove);
}
}
// add item to table
for (auto item_to_add : items_to_add) {
if (!table.contains(item_to_add)) {
table.insert(item_to_add);
}
}
}
// remove whole table
loot_store.erase();
// add whole table
loot_store.insert();
}
```
rektbyfaith
02-03-2023, 11:56 PM #11Archived author: Rymercyble • Posted: 2023-02-03T23:56:15.718000+00:00
Original source
isnt that it though ? consider something like this
```cpp
void OnAfterLootStoreLoaded(LootStore *loot_store)
{
auto items_to_remove;
auto items_to_add;
for (auto table : loot_store) {
// remove item from table
for (auto item_to_remove : items_to_remove) {
if (table.contains(item_to_remove)) {
table.erase(item_to_remove);
}
}
// add item to table
for (auto item_to_add : items_to_add) {
if (!table.contains(item_to_add)) {
table.insert(item_to_add);
}
}
}
// remove whole table
loot_store.erase();
// add whole table
loot_store.insert();
}
```
Original source
we would just need to have such hook
rektbyfaith
02-03-2023, 11:58 PM #12Archived author: Rymercyble • Posted: 2023-02-03T23:58:40.029000+00:00
Original source
we would just need to have such hook
Original source
and if core is not doing checks which i would assume its not then only thing to handle is if reload command is executed
rektbyfaith
02-04-2023, 12:00 AM #13Archived author: Rymercyble • Posted: 2023-02-04T00:00:44.629000+00:00
Original source
and if core is not doing checks which i would assume its not then only thing to handle is if reload command is executed
Original source
Maybe I should just say fudge it and implement a patch system into the core or just stick to the SQL approach in the module.
rektbyfaith
02-04-2023, 12:01 AM #14Archived author: Revision • Posted: 2023-02-04T00:01:11.070000+00:00
Original source
Maybe I should just say fudge it and implement a patch system into the core or just stick to the SQL approach in the module.
Original source
u dont like hackfixing ?
rektbyfaith
02-04-2023, 12:01 AM #15Archived author: Rymercyble • Posted: 2023-02-04T00:01:33.378000+00:00
Original source
u dont like hackfixing ?
Original source
There's just so much to do if this approach would be used. I mean, loot is important but we're talking conditions, disables, dbc data, gossips, transports and so on. I would love to do it but I think it would take so much work.
rektbyfaith
02-04-2023, 12:02 AM #16Archived author: Revision • Posted: 2023-02-04T00:02:53.071000+00:00
Original source
There's just so much to do if this approach would be used. I mean, loot is important but we're talking conditions, disables, dbc data, gossips, transports and so on. I would love to do it but I think it would take so much work.
Original source
I checked out reference method, and it works like a charm
![[Image: World_of_Warcraft_04.02.2023_3_01_35.png...cd40c7225&]](https://cdn.discordapp.com/attachments/284406375495368704/1071219367326519457/World_of_Warcraft_04.02.2023_3_01_35.png?ex=690be5c7&is=690a9447&hm=e04b32a9ce0447bd0987a9062e169c78e0d0e38e3c516ddb56fa208cd40c7225&)
rektbyfaith
02-04-2023, 12:03 AM #17Archived author: Remial • Posted: 2023-02-04T00:03:19.559000+00:00
Original source
I checked out reference method, and it works like a charm
Original source
then i probably misunderstood what u meant it seemed to me like u wanted to avoid changing data in core tables
rektbyfaith
02-04-2023, 12:08 AM #18Archived author: Rymercyble • Posted: 2023-02-04T00:08:43.727000+00:00
Original source
then i probably misunderstood what u meant it seemed to me like u wanted to avoid changing data in core tables
Original source
I do
rektbyfaith
02-04-2023, 12:09 AM #19Archived author: Revision • Posted: 2023-02-04T00:09:26.462000+00:00
Original source
I do
Original source
It's just a lot of work to achieve and I don't know how to do all of it myself
rektbyfaith
02-04-2023, 12:09 AM #20Archived author: Revision • Posted: 2023-02-04T00:09:41.291000+00:00
Original source
It's just a lot of work to achieve and I don't know how to do all of it myself
1 Guest(s)
1 Guest(s)