[DiscordArchive] Wait, is Honey asking for the exposed Warden functions for modules or for the breaking news Warden i
[DiscordArchive] Wait, is Honey asking for the exposed Warden functions for modules or for the breaking news Warden i
Original source
since I don't really want to PR any warden injection on the core, that should stay in a module
rektbyfaith
01-20-2023, 09:54 AM #31Archived author: Anchy • Posted: 2023-01-20T09:54:04.390000+00:00
Original source
since I don't really want to PR any warden injection on the core, that should stay in a module
Original source
Sure
rektbyfaith
01-20-2023, 09:59 AM #32Archived author: Foe • Posted: 2023-01-20T09:59:27.209000+00:00
Original source
Sure
Original source
I like that
rektbyfaith
01-20-2023, 10:08 AM #33Archived author: Honey • Posted: 2023-01-20T10:08:28.133000+00:00
Original source
I like that
Original source
Purrrrrfect
rektbyfaith
01-20-2023, 10:08 AM #34Archived author: Honey • Posted: 2023-01-20T10:08:51.109000+00:00
Original source
Purrrrrfect
Original source
I can probably remove some of the helper functions as well, you don't really need the `void WardenWin::SendChunkedPayload(std:
tring const& lua, uint32 chunkSize)` because it is just a wrapper for the force payload for sending in chunks and can be implemented on the client also
rektbyfaith
01-20-2023, 10:18 AM #35Archived author: Anchy • Posted: 2023-01-20T10:18:16.886000+00:00
Original source
I can probably remove some of the helper functions as well, you don't really need the `void WardenWin::SendChunkedPayload(std:tring const& lua, uint32 chunkSize)` because it is just a wrapper for the force payload for sending in chunks and can be implemented on the client also
Original source
unless that's something you are interested in keeping
rektbyfaith
01-20-2023, 10:18 AM #36Archived author: Anchy • Posted: 2023-01-20T10:18:38.103000+00:00
Original source
unless that's something you are interested in keeping
Original source
but I'll fix the packet size thing for queued payloads
rektbyfaith
01-20-2023, 10:20 AM #37Archived author: Anchy • Posted: 2023-01-20T10:20:05.451000+00:00
Original source
but I'll fix the packet size thing for queued payloads
Original source
I think we should only what's required into the core and take the rest to a module, making use of the exposed functions.
rektbyfaith
01-20-2023, 10:21 AM #38Archived author: Honey • Posted: 2023-01-20T10:21:09.067000+00:00
Original source
I think we should only what's required into the core and take the rest to a module, making use of the exposed functions.
Original source
well one thing with this implementation as well is I have my own queue of payloads that is executed before warden payloads as I'd prefer to separate them and touch Warden as least as possible
rektbyfaith
01-20-2023, 10:22 AM #39Archived author: Anchy • Posted: 2023-01-20T10:22:35.505000+00:00
Original source
well one thing with this implementation as well is I have my own queue of payloads that is executed before warden payloads as I'd prefer to separate them and touch Warden as least as possible
Original source
I'll take a look at it tomorrow and possibly do a PR it's getting too late to work on it confidently lol
rektbyfaith
01-20-2023, 10:24 AM #40Archived author: Anchy • Posted: 2023-01-20T10:24:51.273000+00:00
Original source
I'll take a look at it tomorrow and possibly do a PR it's getting too late to work on it confidently lol
1 Guest(s)
1 Guest(s)