Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] you sure? it looks like the signature of the function it is intended to override changed... maybe?

[DiscordArchive] you sure? it looks like the signature of the function it is intended to override changed... maybe?

[DiscordArchive] you sure? it looks like the signature of the function it is intended to override changed... maybe?

Pages (3): 1 2 3 Next
rektbyfaith
Administrator
0
11-05-2022, 08:12 PM
#1
Archived author: ochbad • Posted: 2022-11-05T20:12:47.275000+00:00
Original source

you sure? it looks like the signature of the function it is intended to override changed... maybe?
rektbyfaith
11-05-2022, 08:12 PM #1

Archived author: ochbad • Posted: 2022-11-05T20:12:47.275000+00:00
Original source

you sure? it looks like the signature of the function it is intended to override changed... maybe?

rektbyfaith
Administrator
0
11-05-2022, 08:13 PM
#2
Archived author: siix • Posted: 2022-11-05T20:13:18.443000+00:00
Original source

you can trace back through the base class(es) to make sure that the overridden function is marked as "virtual"
rektbyfaith
11-05-2022, 08:13 PM #2

Archived author: siix • Posted: 2022-11-05T20:13:18.443000+00:00
Original source

you can trace back through the base class(es) to make sure that the overridden function is marked as "virtual"

rektbyfaith
Administrator
0
11-05-2022, 08:13 PM
#3
Archived author: siix • Posted: 2022-11-05T20:13:38.793000+00:00
Original source

but if kitz is correct and removing override works, then that should do
rektbyfaith
11-05-2022, 08:13 PM #3

Archived author: siix • Posted: 2022-11-05T20:13:38.793000+00:00
Original source

but if kitz is correct and removing override works, then that should do

rektbyfaith
Administrator
0
11-05-2022, 08:14 PM
#4
Archived author: Kitzunu • Posted: 2022-11-05T20:14:00.155000+00:00
Original source

https://github.com/azerothcore/azerothco...5dfc270ed7
[Embed: feat(Core/Scripting): Expand ModifySpellDamageTaken() to include th...]
…… (#13707)

feat(Core/Scripting): Expand ModifySpellDamageTaken() to include the spell data
https://github.com/azerothcore/azerothco...5dfc270ed7
rektbyfaith
11-05-2022, 08:14 PM #4

Archived author: Kitzunu • Posted: 2022-11-05T20:14:00.155000+00:00
Original source

https://github.com/azerothcore/azerothco...5dfc270ed7
[Embed: feat(Core/Scripting): Expand ModifySpellDamageTaken() to include th...]
…… (#13707)

feat(Core/Scripting): Expand ModifySpellDamageTaken() to include the spell data
https://github.com/azerothcore/azerothco...5dfc270ed7

rektbyfaith
Administrator
0
11-05-2022, 08:14 PM
#5
Archived author: ochbad • Posted: 2022-11-05T20:14:28.338000+00:00
Original source

right so the override shoudl have the 4th parameter added to it
rektbyfaith
11-05-2022, 08:14 PM #5

Archived author: ochbad • Posted: 2022-11-05T20:14:28.338000+00:00
Original source

right so the override shoudl have the 4th parameter added to it

rektbyfaith
Administrator
0
11-05-2022, 08:14 PM
#6
Archived author: Kitzunu • Posted: 2022-11-05T20:14:33.397000+00:00
Original source

There are the changes to the base function
rektbyfaith
11-05-2022, 08:14 PM #6

Archived author: Kitzunu • Posted: 2022-11-05T20:14:33.397000+00:00
Original source

There are the changes to the base function

rektbyfaith
Administrator
0
11-05-2022, 08:14 PM
#7
Archived author: ochbad • Posted: 2022-11-05T20:14:36.748000+00:00
Original source

otherwise clients will be calling the wrong cunction?
rektbyfaith
11-05-2022, 08:14 PM #7

Archived author: ochbad • Posted: 2022-11-05T20:14:36.748000+00:00
Original source

otherwise clients will be calling the wrong cunction?

rektbyfaith
Administrator
0
11-05-2022, 08:14 PM
#8
Archived author: ochbad • Posted: 2022-11-05T20:14:45.434000+00:00
Original source

*function
rektbyfaith
11-05-2022, 08:14 PM #8

Archived author: ochbad • Posted: 2022-11-05T20:14:45.434000+00:00
Original source

*function

rektbyfaith
Administrator
0
11-05-2022, 08:15 PM
#9
Archived author: Kitzunu • Posted: 2022-11-05T20:15:05.809000+00:00
Original source

Try
rektbyfaith
11-05-2022, 08:15 PM #9

Archived author: Kitzunu • Posted: 2022-11-05T20:15:05.809000+00:00
Original source

Try

rektbyfaith
Administrator
0
11-05-2022, 08:23 PM
#10
Archived author: ochbad • Posted: 2022-11-05T20:23:12.513000+00:00
Original source

well i guess the nice thing is my change was correct
rektbyfaith
11-05-2022, 08:23 PM #10

Archived author: ochbad • Posted: 2022-11-05T20:23:12.513000+00:00
Original source

well i guess the nice thing is my change was correct

Pages (3): 1 2 3 Next
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)