Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] I might remember wrong, but isnt item guid also only generated on even numbers?

[DiscordArchive] I might remember wrong, but isnt item guid also only generated on even numbers?

[DiscordArchive] I might remember wrong, but isnt item guid also only generated on even numbers?

Pages (6): Previous 1 2 3 4 5 6
rektbyfaith
Administrator
Find
0
02-16-2025, 02:15 PM
#51
Archived author: Err0r • Posted: 2025-02-16T14:15:43.734000+00:00
Original source

```Reoder item guids in item_instance and character_inventory``` Typo
Reply
Reply
rektbyfaith
02-16-2025, 02:15 PM #51

Archived author: Err0r • Posted: 2025-02-16T14:15:43.734000+00:00
Original source

```Reoder item guids in item_instance and character_inventory``` Typo

Reply
Reply
rektbyfaith
Administrator
Find
0
02-16-2025, 02:26 PM
#52
Archived author: Takenbacon • Posted: 2025-02-16T14:26:03.911000+00:00
Original source

Can't quote me on this but I was pretty sure it'll add a lock instruction on its own making it inherently safe but it's obviously not recommended to rely on that lol
Reply
Reply
rektbyfaith
02-16-2025, 02:26 PM #52

Archived author: Takenbacon • Posted: 2025-02-16T14:26:03.911000+00:00
Original source

Can't quote me on this but I was pretty sure it'll add a lock instruction on its own making it inherently safe but it's obviously not recommended to rely on that lol

Reply
Reply
rektbyfaith
Administrator
Find
0
02-16-2025, 02:29 PM
#53
Archived author: Takenbacon • Posted: 2025-02-16T14:29:29.444000+00:00
Original source

Don't need a full memory barrier, make _nextguid atomic and use a fetch_add with relaxed memory order
Reply
Reply
rektbyfaith
02-16-2025, 02:29 PM #53

Archived author: Takenbacon • Posted: 2025-02-16T14:29:29.444000+00:00
Original source

Don't need a full memory barrier, make _nextguid atomic and use a fetch_add with relaxed memory order

Reply
Reply
rektbyfaith
Administrator
Find
0
02-16-2025, 02:36 PM
#54
Archived author: walkline • Posted: 2025-02-16T14:36:41.081000+00:00
Original source

Nice! I have some concerns, though. I'll leave comments in the PR.
Reply
Reply
rektbyfaith
02-16-2025, 02:36 PM #54

Archived author: walkline • Posted: 2025-02-16T14:36:41.081000+00:00
Original source

Nice! I have some concerns, though. I'll leave comments in the PR.

Reply
Reply
rektbyfaith
Administrator
Find
0
02-16-2025, 02:38 PM
#55
Archived author: walkline • Posted: 2025-02-16T14:38:50.054000+00:00
Original source

Yeah, that would probably be the best option. However, we need a separate atomic guid generator specifically for items.
Reply
Reply
rektbyfaith
02-16-2025, 02:38 PM #55

Archived author: walkline • Posted: 2025-02-16T14:38:50.054000+00:00
Original source

Yeah, that would probably be the best option. However, we need a separate atomic guid generator specifically for items.

Reply
Reply
rektbyfaith
Administrator
Find
0
02-16-2025, 02:40 PM
#56
Archived author: Kitzunu • Posted: 2025-02-16T14:40:15.156000+00:00
Original source

yeye
Reply
Reply
rektbyfaith
02-16-2025, 02:40 PM #56

Archived author: Kitzunu • Posted: 2025-02-16T14:40:15.156000+00:00
Original source

yeye

Reply
Reply
Pages (6): Previous 1 2 3 4 5 6
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)