[DiscordArchive] I might remember wrong, but isnt item guid also only generated on even numbers?
[DiscordArchive] I might remember wrong, but isnt item guid also only generated on even numbers?
Original source
wow
rektbyfaith
02-16-2025, 12:24 PM #31Archived author: Kitzunu • Posted: 2025-02-16T12:24:13.969000+00:00
Original source
wow
Original source
Could we potentially create issues if we were to delete the temp item in db before we delete pItem?
rektbyfaith
02-16-2025, 12:42 PM #32Archived author: Kitzunu • Posted: 2025-02-16T12:42:21.659000+00:00
Original source
Could we potentially create issues if we were to delete the temp item in db before we delete pItem?
Original source
I don't think a temp item would ever be stored in the db
rektbyfaith
02-16-2025, 12:50 PM #33Archived author: walkline • Posted: 2025-02-16T12:50:08.569000+00:00
Original source
I don't think a temp item would ever be stored in the db
Original source
oh I see what you are saying, the guid counter on item create doesnt check db but has some internal counter?
rektbyfaith
02-16-2025, 12:50 PM #34Archived author: Kitzunu • Posted: 2025-02-16T12:50:52.886000+00:00
Original source
oh I see what you are saying, the guid counter on item create doesnt check db but has some internal counter?
Original source
I just checked that function and it outputs
```
pItem->GetGUID() 33
pItem->GetGUID() 35
pItem->GetGUID() 37
pItem->GetGUID() 39
pItem->GetGUID() 41
pItem->GetGUID() 43
pItem->GetGUID() 45
pItem->GetGUID() 47
```
which is db guid -1
rektbyfaith
02-16-2025, 12:51 PM #35Archived author: Kitzunu • Posted: 2025-02-16T12:51:12.946000+00:00
Original source
I just checked that function and it outputs
```
pItem->GetGUID() 33
pItem->GetGUID() 35
pItem->GetGUID() 37
pItem->GetGUID() 39
pItem->GetGUID() 41
pItem->GetGUID() 43
pItem->GetGUID() 45
pItem->GetGUID() 47
```
which is db guid -1
Original source
Yeah, we are not directly interacting with the db during item creation. We just using this guid counter - https://github.com/azerothcore/azerothco...#L295-L308
rektbyfaith
02-16-2025, 12:54 PM #36Archived author: walkline • Posted: 2025-02-16T12:54:34.724000+00:00
Original source
Yeah, we are not directly interacting with the db during item creation. We just using this guid counter - https://github.com/azerothcore/azerothco...#L295-L308
Original source
yeah that was what I was getting at
rektbyfaith
02-16-2025, 12:55 PM #37Archived author: Kitzunu • Posted: 2025-02-16T12:55:04.446000+00:00
Original source
yeah that was what I was getting at
Original source
hmm
rektbyfaith
02-16-2025, 12:55 PM #38Archived author: Kitzunu • Posted: 2025-02-16T12:55:06.174000+00:00
Original source
hmm
Original source
and the guid counter is found here
```cpp
result = CharacterDatabase.Query("SELECT MAX(guid) FROM item_instance");
if (result)
GetGuidSequenceGenerator<HighGuid::Item>().Set((*result)[0].Get<uint32>() + 1);
```
So it will always run from max and never fill gaps
rektbyfaith
02-16-2025, 12:58 PM #39Archived author: Kitzunu • Posted: 2025-02-16T12:58:15.385000+00:00
Original source
and the guid counter is found here
```cpp
result = CharacterDatabase.Query("SELECT MAX(guid) FROM item_instance");
if (result)
GetGuidSequenceGenerator<HighGuid::Item>().Set((*result)[0].Get<uint32>() + 1);
```
So it will always run from max and never fill gaps
Original source
interesting
rektbyfaith
02-16-2025, 12:58 PM #40Archived author: Kitzunu • Posted: 2025-02-16T12:58:17.832000+00:00
Original source
interesting
1 Guest(s)
1 Guest(s)