[DiscordArchive] I might remember wrong, but isnt item guid also only generated on even numbers?
[DiscordArchive] I might remember wrong, but isnt item guid also only generated on even numbers?
Archived author: Bench • Posted: 2025-02-16T00:25:47.133000+00:00
Original source
https://tenor.com/view/sub-sandwich-sand...f-26287192
Archived author: Takenbacon • Posted: 2025-02-16T01:21:12.133000+00:00
Original source
Depends on how it generates, I can't recall off the top of my head
Archived author: Takenbacon • Posted: 2025-02-16T01:21:42.353000+00:00
Original source
A sequential number generator would be fine if that's all it did, even without being marked as atomic as it's still inherently an atomic operation on x86
Archived author: Takenbacon • Posted: 2025-02-16T01:33:47.424000+00:00
Original source
Looks to just be an increment. It should be fine
Archived author: Takenbacon • Posted: 2025-02-16T01:34:24.849000+00:00
Original source
Nothing wrong with marking it as atomic if it isn't already though
Archived author: Honey • Posted: 2025-02-16T08:33:45.631000+00:00
Original source
There's an open issue in the mod-eluna repo about that. Since you're probably not using Eluna, it might be a core issue.
Archived author: Kitzunu • Posted: 2025-02-16T08:35:20.419000+00:00
Original source
It is core
ud_despair:1337381443835527298>
Archived author: Honey • Posted: 2025-02-16T08:36:27.212000+00:00
Original source
Then it's old, too. <
ud_despair:1337381443835527298>
Archived author: walkline • Posted: 2025-02-16T09:41:12.886000+00:00
Original source
Are you sure about that? I thought i++ consists of three operations: (1) reading from memory, (2) performing the increment calculation, and (3) writing the result back to memory. If that is the case, then you easily can have guids collision.
Archived author: walkline • Posted: 2025-02-16T12:23:45.525000+00:00
Original source
Player::CanEquipNewItem function creates a temporary item just to check if it can be equipped and then deletes it, but the GUID counter still increases.