[DiscordArchive] If they can improve the code, clean it, and basically do what they're suggesting, why shouldn't they
[DiscordArchive] If they can improve the code, clean it, and basically do what they're suggesting, why shouldn't they
Original source
its once again another example of what could have been in dev branch and fixed over time and im not saying that dev branch should automatically accept every trash there still needs to be some sort of PR review process if that was the case i would never even use master
rektbyfaith
12-14-2023, 03:10 AM #51Archived author: Rymercyble • Posted: 2023-12-14T03:10:03.706000+00:00
Original source
its once again another example of what could have been in dev branch and fixed over time and im not saying that dev branch should automatically accept every trash there still needs to be some sort of PR review process if that was the case i would never even use master
Original source
for average users and servers who dont want to deal with it there would be kind of legacy stable master and everybody else would be on dev
rektbyfaith
12-14-2023, 03:11 AM #52Archived author: Rymercyble • Posted: 2023-12-14T03:11:19.005000+00:00
Original source
for average users and servers who dont want to deal with it there would be kind of legacy stable master and everybody else would be on dev
Original source
and at least from start until there would be some big scripting overhaul all CC fixes for content would be directly compatible with both branches so there is not even that argument
rektbyfaith
12-14-2023, 03:12 AM #53Archived author: Rymercyble • Posted: 2023-12-14T03:12:25.161000+00:00
Original source
and at least from start until there would be some big scripting overhaul all CC fixes for content would be directly compatible with both branches so there is not even that argument
Original source
only thing I ever said about the dbc tables we have was that for whatever reason whoever created them was paid a bounty to do so, therefore they should check with the admins what was the goal behind it, and if they still were of any use
rektbyfaith
12-14-2023, 03:20 AM #54Archived author: Nyeriah • Posted: 2023-12-14T03:20:59.563000+00:00
Original source
only thing I ever said about the dbc tables we have was that for whatever reason whoever created them was paid a bounty to do so, therefore they should check with the admins what was the goal behind it, and if they still were of any use
Original source
no particular disagreement here about it at all, I was even the one who merged one of the referred prs
rektbyfaith
12-14-2023, 03:21 AM #55Archived author: Nyeriah • Posted: 2023-12-14T03:21:20.266000+00:00
Original source
no particular disagreement here about it at all, I was even the one who merged one of the referred prs
Original source
we also tend to try to correct prs and only revert as the last resource (e.g qaston, grids)
rektbyfaith
12-14-2023, 03:22 AM #56Archived author: Nyeriah • Posted: 2023-12-14T03:22:52.968000+00:00
Original source
we also tend to try to correct prs and only revert as the last resource (e.g qaston, grids)
Original source
just to be clear i didnt aim anything directly at u maybe its ur fault maybe its not i dont know im talking about CC as whole which i can admit is a bit unfair towards some members but u chose to be member so
rektbyfaith
12-14-2023, 03:22 AM #57Archived author: Rymercyble • Posted: 2023-12-14T03:22:59.465000+00:00
Original source
just to be clear i didnt aim anything directly at u maybe its ur fault maybe its not i dont know im talking about CC as whole which i can admit is a bit unfair towards some members but u chose to be member so
Original source
I dont remember what was the case here at all
rektbyfaith
12-14-2023, 03:23 AM #58Archived author: Nyeriah • Posted: 2023-12-14T03:23:02.155000+00:00
Original source
I dont remember what was the case here at all
Original source
Ah I merged the revert <:doggokek:1107595041964310528> but I see they reverted it themselves
rektbyfaith
12-14-2023, 03:24 AM #59Archived author: Nyeriah • Posted: 2023-12-14T03:24:48.578000+00:00
Original source
Ah I merged the revert <:doggokek:1107595041964310528> but I see they reverted it themselves
Original source
<:ShaggyWTF:1170999967150776362>
rektbyfaith
12-14-2023, 03:52 AM #60Archived author: Natrist • Posted: 2023-12-14T03:52:10.443000+00:00
Original source
<:ShaggyWTF:1170999967150776362>
1 Guest(s)
1 Guest(s)