[DiscordArchive] If they can improve the code, clean it, and basically do what they're suggesting, why shouldn't they
[DiscordArchive] If they can improve the code, clean it, and basically do what they're suggesting, why shouldn't they
Original source
at least I don't remember it
rektbyfaith
12-14-2023, 02:56 AM #41Archived author: Nyeriah • Posted: 2023-12-14T02:56:57.814000+00:00
Original source
at least I don't remember it
Original source
The reasoning behind someone leaving a group is really between that person and the group and no one else.
rektbyfaith
12-14-2023, 02:57 AM #42Archived author: Revision • Posted: 2023-12-14T02:57:04.101000+00:00
Original source
The reasoning behind someone leaving a group is really between that person and the group and no one else.
Original source
Why it happened is irrelevant to anyone else.
rektbyfaith
12-14-2023, 02:57 AM #43Archived author: Revision • Posted: 2023-12-14T02:57:22.830000+00:00
Original source
Why it happened is irrelevant to anyone else.
Original source
i just wanted to be diplomatic and not bring up heavy guns when its not matter of this topic
rektbyfaith
12-14-2023, 02:57 AM #44Archived author: Rymercyble • Posted: 2023-12-14T02:57:36.449000+00:00
Original source
i just wanted to be diplomatic and not bring up heavy guns when its not matter of this topic
Original source
I do believe M'Dic closed the PR he did because it required testing that he wasn't going to make happen, and the PR that *was* merged had to be reverted because it wasn't tested thoroughly enough
rektbyfaith
12-14-2023, 02:57 AM #45Archived author: Bench • Posted: 2023-12-14T02:57:48.338000+00:00
Original source
I do believe M'Dic closed the PR he did because it required testing that he wasn't going to make happen, and the PR that *was* merged had to be reverted because it wasn't tested thoroughly enough
Original source
to be honest i genuinely dont see what would any1 need to test on such PR u just write code start server check if data is loaded if its correct data (which is already part of development itself) and thats it
rektbyfaith
12-14-2023, 03:00 AM #46Archived author: Rymercyble • Posted: 2023-12-14T03:00:36.440000+00:00
Original source
to be honest i genuinely dont see what would any1 need to test on such PR u just write code start server check if data is loaded if its correct data (which is already part of development itself) and thats it
Original source
Except the way the data was used (since it was pretty darn hardcoded) needed more testing
rektbyfaith
12-14-2023, 03:01 AM #47Archived author: Bench • Posted: 2023-12-14T03:01:09.894000+00:00
Original source
Except the way the data was used (since it was pretty darn hardcoded) needed more testing
Original source
Hence why it caused issues once it was merged
rektbyfaith
12-14-2023, 03:01 AM #48Archived author: Bench • Posted: 2023-12-14T03:01:21.789000+00:00
Original source
Hence why it caused issues once it was merged
Original source
i cant comment i would have to read it
rektbyfaith
12-14-2023, 03:02 AM #49Archived author: Rymercyble • Posted: 2023-12-14T03:02:33.001000+00:00
Original source
i cant comment i would have to read it
Original source
I was mistaken, the PR I was thinking of that was reverted was reverted while M'Dic was still around
https://github.com/azerothcore/azerothco...pull/14843
https://github.com/azerothcore/azerothco...pull/16114
rektbyfaith
12-14-2023, 03:03 AM #50Archived author: Bench • Posted: 2023-12-14T03:03:08.098000+00:00
Original source
I was mistaken, the PR I was thinking of that was reverted was reverted while M'Dic was still around
https://github.com/azerothcore/azerothco...pull/14843
https://github.com/azerothcore/azerothco...pull/16114