[DiscordArchive] If they can improve the code, clean it, and basically do what they're suggesting, why shouldn't they
[DiscordArchive] If they can improve the code, clean it, and basically do what they're suggesting, why shouldn't they
Original source
this is pretty much untrue
rektbyfaith
12-14-2023, 02:42 AM #11Archived author: Nyeriah • Posted: 2023-12-14T02:42:43.067000+00:00
Original source
this is pretty much untrue
Original source
in many aspects, and can be easily refuted tbh
rektbyfaith
12-14-2023, 02:43 AM #12Archived author: Nyeriah • Posted: 2023-12-14T02:43:00.920000+00:00
Original source
in many aspects, and can be easily refuted tbh
Original source
1) "we don't merge things that can't be 100% tested", untrue, see the grid rework
rektbyfaith
12-14-2023, 02:43 AM #13Archived author: Nyeriah • Posted: 2023-12-14T02:43:23.973000+00:00
Original source
1) "we don't merge things that can't be 100% tested", untrue, see the grid rework
Original source
I can't speak about code or managing the code in that sense since I don't touch it at all - I have no reason to have an opinion on it (speaking about qaston and all that)
rektbyfaith
12-14-2023, 02:43 AM #14Archived author: Revision • Posted: 2023-12-14T02:43:30.848000+00:00
Original source
I can't speak about code or managing the code in that sense since I don't touch it at all - I have no reason to have an opinion on it (speaking about qaston and all that)
Original source
2) qaston: it was reverted because it can't be ported 1:1 from trinitycore and there's no amount of manpower to fix every issue
rektbyfaith
12-14-2023, 02:43 AM #15Archived author: Nyeriah • Posted: 2023-12-14T02:43:56.883000+00:00
Original source
2) qaston: it was reverted because it can't be ported 1:1 from trinitycore and there's no amount of manpower to fix every issue
Original source
I know what the response to 2) is going to be already.
rektbyfaith
12-14-2023, 02:44 AM #16Archived author: Revision • Posted: 2023-12-14T02:44:13.796000+00:00
Original source
I know what the response to 2) is going to be already.
Original source
3) "we don't merge things if they aren't 100% accurate", untrue, being an improvement is already enough to get something merged, however we dont merge just about anything. if it contradicts sniffs, we are likely to block it, if we can research it, we are also likely to block it and fix it with proper data. sometimes it takes longer to merge a pr, however it gets a definite fix instead of a temporary one
rektbyfaith
12-14-2023, 02:45 AM #17Archived author: Nyeriah • Posted: 2023-12-14T02:45:23.008000+00:00
Original source
3) "we don't merge things if they aren't 100% accurate", untrue, being an improvement is already enough to get something merged, however we dont merge just about anything. if it contradicts sniffs, we are likely to block it, if we can research it, we are also likely to block it and fix it with proper data. sometimes it takes longer to merge a pr, however it gets a definite fix instead of a temporary one
Original source
i didnt mean every single time i can admit it might look like it but im thinking about fact that it happened multiple times
rektbyfaith
12-14-2023, 02:45 AM #18Archived author: Rymercyble • Posted: 2023-12-14T02:45:35.216000+00:00
Original source
i didnt mean every single time i can admit it might look like it but im thinking about fact that it happened multiple times
Original source
that is not justification of lack of existance of dev branch where it could stay and be fixed over time
rektbyfaith
12-14-2023, 02:46 AM #19Archived author: Rymercyble • Posted: 2023-12-14T02:46:04.434000+00:00
Original source
that is not justification of lack of existance of dev branch where it could stay and be fixed over time
Original source
the issue is maintaining said dev branch up to date and having someone willing to do it (there's no one)
rektbyfaith
12-14-2023, 02:46 AM #20Archived author: Nyeriah • Posted: 2023-12-14T02:46:43.723000+00:00
Original source
the issue is maintaining said dev branch up to date and having someone willing to do it (there's no one)
1 Guest(s)
1 Guest(s)