[DiscordArchive] If they can improve the code, clean it, and basically do what they're suggesting, why shouldn't they
[DiscordArchive] If they can improve the code, clean it, and basically do what they're suggesting, why shouldn't they
Original source
If they can improve the code, clean it, and basically do what they're suggesting, why shouldn't they be?
rektbyfaith
12-14-2023, 02:32 AM #1Archived author: Revision • Posted: 2023-12-14T02:32:04.411000+00:00
Original source
If they can improve the code, clean it, and basically do what they're suggesting, why shouldn't they be?
Original source
when i say maintainer i mean those who CC picked to work with and gave them access to hidden channels and is more discussing internally what to do or not do
rektbyfaith
12-14-2023, 02:34 AM #2Archived author: Rymercyble • Posted: 2023-12-14T02:34:10.779000+00:00
Original source
when i say maintainer i mean those who CC picked to work with and gave them access to hidden channels and is more discussing internally what to do or not do
Original source
The last one is just stupid. Not that you said it but that it's sometimes true. It's too hard to test. That's no excuse in any way. The proof thing is a bit iffy imo, it's impossible to prove something if no evidence is available since the game isn't available anymore (Classic isn't identical) so sometimes one has to make a judgement call and use what little evidence is available to make a decision. Can't **automatically** reject improvements just because they **might** not be 100% blizzlike
rektbyfaith
12-14-2023, 02:34 AM #3Archived author: Revision • Posted: 2023-12-14T02:34:13.720000+00:00
Original source
The last one is just stupid. Not that you said it but that it's sometimes true. It's too hard to test. That's no excuse in any way. The proof thing is a bit iffy imo, it's impossible to prove something if no evidence is available since the game isn't available anymore (Classic isn't identical) so sometimes one has to make a judgement call and use what little evidence is available to make a decision. Can't **automatically** reject improvements just because they **might** not be 100% blizzlike
Original source
both cases which i said happend and not just once there is nothing to talk about here
rektbyfaith
12-14-2023, 02:35 AM #4Archived author: Rymercyble • Posted: 2023-12-14T02:35:31.096000+00:00
Original source
both cases which i said happend and not just once there is nothing to talk about here
Original source
I know it has happened. I'm not talking about it to prove you wrong but just say that the logic of denying code because "it's hard to test" or "you need to prove it's 100% blizzlike or you will always get rejected" is just a terrible mindset.
rektbyfaith
12-14-2023, 02:36 AM #5Archived author: Revision • Posted: 2023-12-14T02:36:25.819000+00:00
Original source
I know it has happened. I'm not talking about it to prove you wrong but just say that the logic of denying code because "it's hard to test" or "you need to prove it's 100% blizzlike or you will always get rejected" is just a terrible mindset.
Original source
so is that that u agree with me or is that argument against what i said ? <:kek:1065379143887372398>
rektbyfaith
12-14-2023, 02:38 AM #6Archived author: Rymercyble • Posted: 2023-12-14T02:38:02.189000+00:00
Original source
so is that that u agree with me or is that argument against what i said ? <:kek:1065379143887372398>
Original source
I'm agreeing with you, more or less.
rektbyfaith
12-14-2023, 02:38 AM #7Archived author: Revision • Posted: 2023-12-14T02:38:25.124000+00:00
Original source
I'm agreeing with you, more or less.
Original source
nice
rektbyfaith
12-14-2023, 02:38 AM #8Archived author: Rymercyble • Posted: 2023-12-14T02:38:34.504000+00:00
Original source
nice
Original source
but like i said i can understand that they want stable master but if there at least was dev branch where these changes would be accepted
rektbyfaith
12-14-2023, 02:39 AM #9Archived author: Rymercyble • Posted: 2023-12-14T02:39:03.664000+00:00
Original source
but like i said i can understand that they want stable master but if there at least was dev branch where these changes would be accepted
Original source
lets say qaston they reverted it and original branch is deleted and its 1 year old so its in state where updating it to current version is more or less same amount of work as porting it once again if we had dev branch where it would stay and be regularly updated we would be half done even if nothing was done on it since then
rektbyfaith
12-14-2023, 02:41 AM #10Archived author: Rymercyble • Posted: 2023-12-14T02:41:54.827000+00:00
Original source
lets say qaston they reverted it and original branch is deleted and its 1 year old so its in state where updating it to current version is more or less same amount of work as porting it once again if we had dev branch where it would stay and be regularly updated we would be half done even if nothing was done on it since then