[DiscordArchive] Have you seen the code that references it?
[DiscordArchive] Have you seen the code that references it?
Archived author: Kitzunu • Posted: 2023-11-21T18:09:29.272000+00:00
Original source
WorldSession helper to accountmgr <:pog:1075101149583134842>
Archived author: Natrist • Posted: 2023-11-21T18:09:46.348000+00:00
Original source
Well, here's my idea for AccountMgr:
Archived author: Natrist • Posted: 2023-11-21T18:10:11.932000+00:00
Original source
Rename it to AccountSvcs or AccountServices, whatever you prefer. That makes more sense and explains what it does (what the hell is an account manager anyway?).
Archived author: Natrist • Posted: 2023-11-21T18:10:34.951000+00:00
Original source
Next, remove the security checking functions, as that namespace will only handle account services, aka, creating, deleting, setting password, etc.
Archived author: Nyeriah • Posted: 2023-11-21T18:10:42.633000+00:00
Original source
It’s just the default nomenclature used in the core. Everything is an ObjMgr
Archived author: Natrist • Posted: 2023-11-21T18:11:21.034000+00:00
Original source
Yeah, I get that.
Archived author: Bench • Posted: 2023-11-21T18:12:12.381000+00:00
Original source
IMO config should stay, configs don't hurt enough to warrant removal, 'specially not that one
Archived author: Kitzunu • Posted: 2023-11-21T18:12:16.425000+00:00
Original source
I am still on the team of, if it is player related keep it in player, if it is unit related keep it in unit, if it is account related keep it in account. Add helpers or whatnot sure. But maybe just me
Archived author: Natrist • Posted: 2023-11-21T18:12:40.386000+00:00
Original source
Yeah that's because you have no experience writing professional code.
Archived author: Natrist • Posted: 2023-11-21T18:12:54.875000+00:00
Original source
Sorry to put is so bluntly, but you need to think in terms of people using your code.