[DiscordArchive] Have you seen the code that references it?
[DiscordArchive] Have you seen the code that references it?
Original source
Also why would you move IsGMAccount to worldsession. Has everything to do with account and nothing to do with worldsession
rektbyfaith
11-21-2023, 06:03 PM #11Archived author: Kitzunu • Posted: 2023-11-21T18:03:20.748000+00:00
Original source
Also why would you move IsGMAccount to worldsession. Has everything to do with account and nothing to do with worldsession
Original source
Let me show you. Like they say, a picture is worth a thousand words.
rektbyfaith
11-21-2023, 06:04 PM #12Archived author: Natrist • Posted: 2023-11-21T18:04:10.649000+00:00
Original source
Let me show you. Like they say, a picture is worth a thousand words.
Original source
![[Image: Screenshot_2023-11-21_at_1.04.48_PM.png?...1ce5babf7&]](https://cdn.discordapp.com/attachments/284323424032129024/1176584081597800518/Screenshot_2023-11-21_at_1.04.48_PM.png?ex=690c3a90&is=690ae910&hm=949307ce51cbbe51236b985534f8f446e0c5d2e4739f788bb98e19a1ce5babf7&)
rektbyfaith
11-21-2023, 06:05 PM #13Archived author: Natrist • Posted: 2023-11-21T18:05:04.996000+00:00
Original source
Original source
The current implementation is a monstrosity. Not only does it make no sense whatsoever in implementation but it's also awkward to call and is lengthy for no valid reason.
rektbyfaith
11-21-2023, 06:05 PM #14Archived author: Natrist • Posted: 2023-11-21T18:05:38.359000+00:00
Original source
The current implementation is a monstrosity. Not only does it make no sense whatsoever in implementation but it's also awkward to call and is lengthy for no valid reason.
Original source
Also, I would recommend renaming GetSession() to Session() for the sake of simplicity.
rektbyfaith
11-21-2023, 06:06 PM #15Archived author: Natrist • Posted: 2023-11-21T18:06:05.786000+00:00
Original source
Also, I would recommend renaming GetSession() to Session() for the sake of simplicity.
Original source
well in the best of worlds we wouldnt have security levels, but rbac
rektbyfaith
11-21-2023, 06:07 PM #16Archived author: Kitzunu • Posted: 2023-11-21T18:07:26.039000+00:00
Original source
well in the best of worlds we wouldnt have security levels, but rbac
Original source
We can do anything we want, that's the beauty of programming.
rektbyfaith
11-21-2023, 06:07 PM #17Archived author: Natrist • Posted: 2023-11-21T18:07:43.727000+00:00
Original source
We can do anything we want, that's the beauty of programming.
Original source
Right now, the way I see it, few new features will make it. We should focus on refactoring the code and simplifying everything for the end user.
rektbyfaith
11-21-2023, 06:08 PM #18Archived author: Natrist • Posted: 2023-11-21T18:08:25.070000+00:00
Original source
Right now, the way I see it, few new features will make it. We should focus on refactoring the code and simplifying everything for the end user.
Original source
Most of what I see is potato potatoes tbh. I don’t have issues with a helper added to session though
rektbyfaith
11-21-2023, 06:08 PM #19Archived author: Nyeriah • Posted: 2023-11-21T18:08:50.441000+00:00
Original source
Most of what I see is potato potatoes tbh. I don’t have issues with a helper added to session though
Original source
We can probably reduce the code by 30% while making it clearer and more performant.
rektbyfaith
11-21-2023, 06:08 PM #20Archived author: Natrist • Posted: 2023-11-21T18:08:57.578000+00:00
Original source
We can probably reduce the code by 30% while making it clearer and more performant.
1 Guest(s)
1 Guest(s)