[DiscordArchive] So if the hook doesn't exist, can I request it or send in a PR?
[DiscordArchive] So if the hook doesn't exist, can I request it or send in a PR?
Archived author: Natrist • Posted: 2023-09-26T20:47:01.668000+00:00
Original source
So if the hook doesn't exist, can I request it or send in a PR?
Archived author: Foe • Posted: 2023-09-26T20:47:02.550000+00:00
Original source
It uses the scriptmgr api to expose hooks, pretty much exactly like scripts but with predefined cmake ambiguity
Archived author: Bench • Posted: 2023-09-26T20:47:11.662000+00:00
Original source
Yes
Archived author: Natrist • Posted: 2023-09-26T20:47:19.132000+00:00
Original source
Ah, gotcha. This is cool.
Archived author: Bench • Posted: 2023-09-26T20:47:39.961000+00:00
Original source
Though hook requests don't get fulfilled very often by people not actively working to use it
Archived author: Natrist • Posted: 2023-09-26T20:48:20.912000+00:00
Original source
If I can open a PR it will be reviewed and likely accepted, though. Right?
Archived author: Bench • Posted: 2023-09-26T20:48:29.051000+00:00
Original source
Yep
Archived author: Bench • Posted: 2023-09-26T20:48:38.277000+00:00
Original source
Happens mildly regularly
Archived author: Revision • Posted: 2023-09-26T20:48:58.508000+00:00
Original source
Likely is relative. It depends on the quality of the code and all that. It can be accepted, yes.
Archived author: Natrist • Posted: 2023-09-26T20:49:29.523000+00:00
Original source
Is there documentation for the creation of modules? I don't see any on the wiki