[DiscordArchive] So if the hook doesn't exist, can I request it or send in a PR?
[DiscordArchive] So if the hook doesn't exist, can I request it or send in a PR?
Original source
Not anything thorough afaik, most I've heard just look at other modules as examples
rektbyfaith
09-26-2023, 08:49 PM #11Archived author: Bench • Posted: 2023-09-26T20:49:56.626000+00:00
Original source
Not anything thorough afaik, most I've heard just look at other modules as examples
Original source
You didn't look very hard in the list on the left: https://www.azerothcore.org/wiki/create-a-module
rektbyfaith
09-26-2023, 08:50 PM #12Archived author: Revision • Posted: 2023-09-26T20:50:09.384000+00:00
Original source
You didn't look very hard in the list on the left: https://www.azerothcore.org/wiki/create-a-module
Original source
Oh! My bad, hehe. I was expecting that to be under the **Contribute** section
rektbyfaith
09-26-2023, 08:50 PM #13Archived author: Natrist • Posted: 2023-09-26T20:50:48.629000+00:00
Original source
Oh! My bad, hehe. I was expecting that to be under the **Contribute** section
Original source
Yea the wiki ain't organized too intuitively (though you can hurl PRs at that too)
rektbyfaith
09-26-2023, 08:51 PM #14Archived author: Bench • Posted: 2023-09-26T20:51:30.496000+00:00
Original source
Yea the wiki ain't organized too intuitively (though you can hurl PRs at that too)
Original source
Is that not just a little QA debug menu on the side or was that for a different team? Cause iirc there's a pretty common GM type addon for VMaNGOS admins which recreates that menu through running GM commands I'd imagine
rektbyfaith
09-26-2023, 08:57 PM #15Archived author: Bench • Posted: 2023-09-26T20:57:40.985000+00:00
Original source
Is that not just a little QA debug menu on the side or was that for a different team? Cause iirc there's a pretty common GM type addon for VMaNGOS admins which recreates that menu through running GM commands I'd imagine
Original source
If it is a separate thing, I'd be lying if I said I wasn't interested myself
rektbyfaith
09-26-2023, 08:58 PM #16Archived author: Bench • Posted: 2023-09-26T20:58:05.787000+00:00
Original source
If it is a separate thing, I'd be lying if I said I wasn't interested myself
Original source
No, it's an actual 1 for 1 reproduction of the real thing Blizzard used internally.
rektbyfaith
09-26-2023, 08:59 PM #17Archived author: Natrist • Posted: 2023-09-26T20:59:19.195000+00:00
Original source
No, it's an actual 1 for 1 reproduction of the real thing Blizzard used internally.
Original source
I have AddOns that go with it as well.
rektbyfaith
09-26-2023, 08:59 PM #18Archived author: Natrist • Posted: 2023-09-26T20:59:36.272000+00:00
Original source
I have AddOns that go with it as well.
Original source
Would it be acceptable for me to send PRs that implement server-side features that aren't normally queried by the client but exist nonetheless internally and for which I have tangible knowledge? For example, many packets are used by the GM client or internal tools and aren't implemented in emulators.
rektbyfaith
09-26-2023, 09:07 PM #19Archived author: Natrist • Posted: 2023-09-26T21:07:08.824000+00:00
Original source
Would it be acceptable for me to send PRs that implement server-side features that aren't normally queried by the client but exist nonetheless internally and for which I have tangible knowledge? For example, many packets are used by the GM client or internal tools and aren't implemented in emulators.
Original source
There's no reason why packet handlers shouldn't be implemented even if the client doesn't normally send those packets, as long as they are part of the base client
rektbyfaith
09-26-2023, 09:08 PM #20Archived author: Foe • Posted: 2023-09-26T21:08:08.130000+00:00
Original source
There's no reason why packet handlers shouldn't be implemented even if the client doesn't normally send those packets, as long as they are part of the base client
1 Guest(s)
1 Guest(s)