[DiscordArchive] i'll figure out how to get better segfault logs out of worldserver, see where its actually failing.
[DiscordArchive] i'll figure out how to get better segfault logs out of worldserver, see where its actually failing.
Original source
haven't fixed it yet but i did confirm that we suspected is happening is definitely what's happening.
![[Image: image.png?ex=690c1ff2&is=690ace72&hm=cd8...3feb6ea88&]](https://cdn.discordapp.com/attachments/284323424032129024/1105708671633207316/image.png?ex=690c1ff2&is=690ace72&hm=cd8f93ccaf77b08069adb5616f5fdb4b9de67f23203ab33a8375c4e3feb6ea88&)
rektbyfaith
05-10-2023, 04:11 AM #21Archived author: KJack • Posted: 2023-05-10T04:11:30.435000+00:00
Original source
haven't fixed it yet but i did confirm that we suspected is happening is definitely what's happening.
Original source
you could check to see if the item exists before accessing it
rektbyfaith
05-10-2023, 04:24 AM #22Archived author: Anchy • Posted: 2023-05-10T04:24:22.033000+00:00
Original source
you could check to see if the item exists before accessing it
Original source
although it looks like from the code snippet you posted it already does that
rektbyfaith
05-10-2023, 04:36 AM #23Archived author: Anchy • Posted: 2023-05-10T04:36:57.203000+00:00
Original source
although it looks like from the code snippet you posted it already does that
Original source
it likely the item is deleted later so like Nyeriah said you would need a delay
rektbyfaith
05-10-2023, 04:37 AM #24Archived author: Anchy • Posted: 2023-05-10T04:37:29.121000+00:00
Original source
it likely the item is deleted later so like Nyeriah said you would need a delay
Original source
it helps if i read all the previous comments instead of just repeating what you all said
rektbyfaith
05-10-2023, 04:38 AM #25Archived author: Anchy • Posted: 2023-05-10T04:38:00.366000+00:00
Original source
it helps if i read all the previous comments instead of just repeating what you all said
Original source
you're on the same road I am, I just have been on it longer. This fixed it.
![[Image: image.png?ex=690c2af3&is=690ad973&hm=793...7fb09a28b&]](https://cdn.discordapp.com/attachments/284323424032129024/1105720489483182120/image.png?ex=690c2af3&is=690ad973&hm=793c57bae7fcc30a386d9c8641893f5e5ea74cb86002151181050527fb09a28b&)
rektbyfaith
05-10-2023, 04:58 AM #26Archived author: KJack • Posted: 2023-05-10T04:58:27.933000+00:00
Original source
you're on the same road I am, I just have been on it longer. This fixed it.
Original source
i *think* what's happening is that the `!item` check was passing because the pointer still exists, it just doesn't point to anything anymore. so i added a check to ensure that the dereferenced pointer was still an item. if not, return.
rektbyfaith
05-10-2023, 04:59 AM #27Archived author: KJack • Posted: 2023-05-10T04:59:15.336000+00:00
Original source
i *think* what's happening is that the `!item` check was passing because the pointer still exists, it just doesn't point to anything anymore. so i added a check to ensure that the dereferenced pointer was still an item. if not, return.
Original source
any `Item` function call to that pointer was crashing the server, so I figured it must not be an `Item` anymore.
rektbyfaith
05-10-2023, 04:59 AM #28Archived author: KJack • Posted: 2023-05-10T04:59:45.597000+00:00
Original source
any `Item` function call to that pointer was crashing the server, so I figured it must not be an `Item` anymore.
Original source
<@234784691608092682>
https://github.com/azerothcore/mod-transmog/pull/123
[Embed: (bug) Adds check to OnLootItem() to ensure that the pointer is stil...]
Found this bug when testing out a new module: https://github.com/noisiver/mod-junk-to-gold
junk-to-gold also uses the OnLootItem function and was being called BEFORE transmog. By the time transmog ...
https://github.com/azerothcore/mod-transmog/pull/123
rektbyfaith
05-10-2023, 05:03 AM #29Archived author: KJack • Posted: 2023-05-10T05:03:48.176000+00:00
Original source
<@234784691608092682>
https://github.com/azerothcore/mod-transmog/pull/123
[Embed: (bug) Adds check to OnLootItem() to ensure that the pointer is stil...]
Found this bug when testing out a new module: https://github.com/noisiver/mod-junk-to-gold
junk-to-gold also uses the OnLootItem function and was being called BEFORE transmog. By the time transmog ...
https://github.com/azerothcore/mod-transmog/pull/123
Original source
submitted my first AzerothCore PR to add a `Rate.Drop.Item.GroupAmount` setting in `worldserver.conf`. Since I'm new, anything I need to do to follow up on it or is it ready for review as-is?
rektbyfaith
05-10-2023, 05:14 AM #30Archived author: KJack • Posted: 2023-05-10T05:14:01.980000+00:00
Original source
submitted my first AzerothCore PR to add a `Rate.Drop.Item.GroupAmount` setting in `worldserver.conf`. Since I'm new, anything I need to do to follow up on it or is it ready for review as-is?
1 Guest(s)
1 Guest(s)