Forums WoW Modding Support Archives WoWModding Support Archives [DiscordArchive] I'd like to change my fork of the WDBXEditor2 to use the DBCD library writing (it's currently using

[DiscordArchive] I'd like to change my fork of the WDBXEditor2 to use the DBCD library writing (it's currently using

[DiscordArchive] I'd like to change my fork of the WDBXEditor2 to use the DBCD library writing (it's currently using

rektbyfaith
Administrator
0
08-15-2024, 09:39 AM
#1
Archived author: KalopsiaTwilight • Posted: 2024-08-15T09:39:40.637000+00:00
Original source

I'd like to change my fork of the WDBXEditor2 to use the DBCD library writing (it's currently using its own fork of DBCD) so I can contribute my own observations from writing/editing 9.2.7 WDC3 files but I have some issues that I am running into with the DBCDStorage API that I ran into with the original sources in MaxtorCoder's WDBXEditor2 as well.

For instance, there's no way to access the data in the Storage<T> of a DBCDStorage, which means that calling .Clear() or .Remove() doesn't actually delete the data when you'd later write the storage out.

I am considering making an issue/PR for the things I ran into, would you prefer to have everything in one issue/PR or should I make seperate issues/PRs for each type of issue?
rektbyfaith
08-15-2024, 09:39 AM #1

Archived author: KalopsiaTwilight • Posted: 2024-08-15T09:39:40.637000+00:00
Original source

I'd like to change my fork of the WDBXEditor2 to use the DBCD library writing (it's currently using its own fork of DBCD) so I can contribute my own observations from writing/editing 9.2.7 WDC3 files but I have some issues that I am running into with the DBCDStorage API that I ran into with the original sources in MaxtorCoder's WDBXEditor2 as well.

For instance, there's no way to access the data in the Storage<T> of a DBCDStorage, which means that calling .Clear() or .Remove() doesn't actually delete the data when you'd later write the storage out.

I am considering making an issue/PR for the things I ran into, would you prefer to have everything in one issue/PR or should I make seperate issues/PRs for each type of issue?

rektbyfaith
Administrator
0
08-15-2024, 09:45 AM
#2
Archived author: Marlamin • Posted: 2024-08-15T09:45:18.678000+00:00
Original source

the ToDictionary() call on a storage gives you the internal dictionary
rektbyfaith
08-15-2024, 09:45 AM #2

Archived author: Marlamin • Posted: 2024-08-15T09:45:18.678000+00:00
Original source

the ToDictionary() call on a storage gives you the internal dictionary

rektbyfaith
Administrator
0
08-15-2024, 09:45 AM
#3
Archived author: Marlamin • Posted: 2024-08-15T09:45:23.222000+00:00
Original source

any changes to that should apply when Save()ing out
rektbyfaith
08-15-2024, 09:45 AM #3

Archived author: Marlamin • Posted: 2024-08-15T09:45:23.222000+00:00
Original source

any changes to that should apply when Save()ing out

rektbyfaith
Administrator
0
08-15-2024, 09:46 AM
#4
Archived author: Marlamin • Posted: 2024-08-15T09:46:06.711000+00:00
Original source

but sure, any PRs are welcome with enough explanation as to why they'd be needed and without changing too much of the API
rektbyfaith
08-15-2024, 09:46 AM #4

Archived author: Marlamin • Posted: 2024-08-15T09:46:06.711000+00:00
Original source

but sure, any PRs are welcome with enough explanation as to why they'd be needed and without changing too much of the API

rektbyfaith
Administrator
0
08-15-2024, 09:47 AM
#5
Archived author: Marlamin • Posted: 2024-08-15T09:47:43.477000+00:00
Original source

eg
```csharp
var storage = dbcd.Load("Achievement", build);
var dict = storage.ToDictionary();
dict.Clear();
storage.Save("Achievement.db2");
```
generates this empty db2
rektbyfaith
08-15-2024, 09:47 AM #5

Archived author: Marlamin • Posted: 2024-08-15T09:47:43.477000+00:00
Original source

eg
```csharp
var storage = dbcd.Load("Achievement", build);
var dict = storage.ToDictionary();
dict.Clear();
storage.Save("Achievement.db2");
```
generates this empty db2

rektbyfaith
Administrator
0
08-15-2024, 09:47 AM
#6
Archived author: Marlamin • Posted: 2024-08-15T09:47:46.971000+00:00
Original source


[Image: image.png?ex=690c6ec3&is=690b1d43&hm=148...85f92ba7d&]
rektbyfaith
08-15-2024, 09:47 AM #6

Archived author: Marlamin • Posted: 2024-08-15T09:47:46.971000+00:00
Original source


[Image: image.png?ex=690c6ec3&is=690b1d43&hm=148...85f92ba7d&]

Recently Browsing
 
Recently Browsing