[DiscordArchive] are you running it on wine?
[DiscordArchive] are you running it on wine?
Original source
are you running it on wine?
rektbyfaith
05-16-2024, 05:58 AM #1Archived author: Ĝ̷̳r̸̹͊a̷̜̚k̴̞̔ • Posted: 2024-05-16T05:58:17.308000+00:00
Original source
are you running it on wine?
Original source
maybe its just my vm thats wonky then
rektbyfaith
05-16-2024, 06:00 AM #2Archived author: Ĝ̷̳r̸̹͊a̷̜̚k̴̞̔ • Posted: 2024-05-16T06:00:16.567000+00:00
Original source
maybe its just my vm thats wonky then
Original source
No
rektbyfaith
05-16-2024, 06:04 AM #3Archived author: A2 • Posted: 2024-05-16T06:04:13.406000+00:00
Original source
No
Original source
I think you’re overreacting lol.
There is no problem with having multiple static/global arrays with the size ~1,5k.
On startup it’s allocating 200kb (the size of struct is 12bytes = 12*17 000) of RAM which is not a big deal for modern systems.
Here is example of allocating and deallocating 65kb on heap, every millisecond, for every socket, and nobody has cared for years - https://github.com/TrinityCore/TrinityCo...et.cpp#L84
[Embed: TrinityCore/src/server/game/Server/WorldSocket.cpp at 400aef35a19f9...]
TrinityCore Open Source MMO Framework (master = 10.2.7.54717, 3.3.5 = 3.3.5a.12340, wotlk_classic = 3.4.3.54261, cata classic = 4.4.0.54027) - TrinityCore/TrinityCore
https://github.com/TrinityCore/TrinityCo...Socket.cpp
rektbyfaith
05-16-2024, 07:49 AM #4Archived author: walkline • Posted: 2024-05-16T07:49:07.469000+00:00
Original source
I think you’re overreacting lol.
There is no problem with having multiple static/global arrays with the size ~1,5k.
On startup it’s allocating 200kb (the size of struct is 12bytes = 12*17 000) of RAM which is not a big deal for modern systems.
Here is example of allocating and deallocating 65kb on heap, every millisecond, for every socket, and nobody has cared for years - https://github.com/TrinityCore/TrinityCo...et.cpp#L84
[Embed: TrinityCore/src/server/game/Server/WorldSocket.cpp at 400aef35a19f9...]
TrinityCore Open Source MMO Framework (master = 10.2.7.54717, 3.3.5 = 3.3.5a.12340, wotlk_classic = 3.4.3.54261, cata classic = 4.4.0.54027) - TrinityCore/TrinityCore
https://github.com/TrinityCore/TrinityCo...Socket.cpp
Original source
^
rektbyfaith
05-16-2024, 08:00 AM #5Archived author: Kaev • Posted: 2024-05-16T08:00:57.739000+00:00
Original source
^
Original source
objectively there is no good reason to have that hardcoded
rektbyfaith
05-16-2024, 08:04 AM #6Archived author: Kaev • Posted: 2024-05-16T08:04:37.806000+00:00
Original source
objectively there is no good reason to have that hardcoded
Original source
It would be such a good idea to pull out the `instance_template` table from DB and hard code it in the core, it's only a hundred rows at best. Will be great.
And if you think _that's_ retarded to do, then the inverse of _not_ putting this in the DB is too.
rektbyfaith
05-16-2024, 08:06 AM #7Archived author: Deleted User • Posted: 2024-05-16T08:06:50.190000+00:00
Original source
It would be such a good idea to pull out the `instance_template` table from DB and hard code it in the core, it's only a hundred rows at best. Will be great.
And if you think _that's_ retarded to do, then the inverse of _not_ putting this in the DB is too.
Original source
I mean, in general, I agree that AC has lower code quality standards and so on and so forth. But I don’t get why you are referring to this particular PR. This PR is about an event that happens once a year (I didn’t even know it existed). I believe there is no data structure in the database that fits the need (I wouldn’t want to support it as SAI). Creating a new data structure in the database and implementing the code to manage this data would be over-engineering.
If I were to implement it, I wouldn’t rely on sniffs and would use some sort of random values calculated at runtime. But the author's implementation also makes sense if you want to make it accurate.
rektbyfaith
05-16-2024, 08:20 AM #8Archived author: walkline • Posted: 2024-05-16T08:20:40.215000+00:00
Original source
I mean, in general, I agree that AC has lower code quality standards and so on and so forth. But I don’t get why you are referring to this particular PR. This PR is about an event that happens once a year (I didn’t even know it existed). I believe there is no data structure in the database that fits the need (I wouldn’t want to support it as SAI). Creating a new data structure in the database and implementing the code to manage this data would be over-engineering.
If I were to implement it, I wouldn’t rely on sniffs and would use some sort of random values calculated at runtime. But the author's implementation also makes sense if you want to make it accurate.