[DiscordArchive] Does someone know why TC applies ```UNIT_FLAG_PLAYER_CONTROLLED``` for ```void AuraEffect::HandleAur
[DiscordArchive] Does someone know why TC applies ```UNIT_FLAG_PLAYER_CONTROLLED``` for ```void AuraEffect::HandleAur
Archived author: robinsch • Posted: 2022-11-29T14:52:30.023000+00:00
Original source
Does someone know why TC applies ```UNIT_FLAG_PLAYER_CONTROLLED``` for ```void AuraEffect::HandleAuraModFaction``` handler?
Archived author: <o> • Posted: 2022-11-29T14:57:44.143000+00:00
Original source
most likely some quest
Archived author: robinsch • Posted: 2022-11-29T14:58:14.504000+00:00
Original source
I think it's kinda misused and incorrect.
Archived author: robinsch • Posted: 2022-11-29T14:59:24.929000+00:00
Original source
it causes a bunch of checks to return false such as:
> CGUnit_C::CanAssist
> CGUnit_C::IsUnitInGroup
Archived author: <o> • Posted: 2022-11-29T15:00:01.419000+00:00
Original source
there's only a very small amount of dbc spells using it;
```
44281: Zombie Tech Test
44305: You're a ...! (Effects2)
44526: Hate Monster (Spar) (30 sec)
44527: Hate Monster (Spar Buddy) (30 sec)
44819: Hate Monster (Spar Buddy) (>30% Health)
44820: Hate Monster (Spar) (<30%)
45056: HolidayRobot Faction Override
45091: Faction, Spar
46761: Faction - Hates Self (10 sec.)
49059: Horde, Hate Monster (Spar Buddy) (>30% Health)
62323: Hookshot
65403: Ride Vehicle
75018: Zalazane's Fool
```
Archived author: <o> • Posted: 2022-11-29T15:00:11.769000+00:00
Original source
and one db spelll 45092
Archived author: <o> • Posted: 2022-11-29T15:00:59.286000+00:00
Original source
you can try changing it and backtrace those spells and see if it breaks the quests/scripts that use them
Archived author: robinsch • Posted: 2022-11-29T15:02:21.484000+00:00
Original source
Do you recognize some that can be applied to players?
Archived author: robinsch • Posted: 2022-11-29T15:03:09.411000+00:00
Original source
We certainly misused the aura effect for some custom implementations. Might not be an issue otherwise
Archived author: robinsch • Posted: 2022-11-29T15:10:06.185000+00:00
Original source
Yeah I think ```HandleAuraModFaction``` should only be used if it makes you totally hostile to any player faction ...