[DiscordArchive] THis does not seem correct at all? <@200677690838220800> Is it?
[DiscordArchive] THis does not seem correct at all? <@200677690838220800> Is it?
Original source
Kek
rektbyfaith
10-16-2025, 01:57 PM #11Archived author: MaxtorCoder • Posted: 2025-10-16T13:57:26.122000+00:00
Original source
Kek
Original source
``` {
_worldPacket >> BitsSize<5>(Groups);
for (auto& group : Groups)
{
_worldPacket >> group.GroupID;
_worldPacket >> group.OrderIndex;
_worldPacket >> group.WarbandSceneID;
_worldPacket >> As<uint32>(group.Flags);
_worldPacket >> Size<uint32>(group.Members);
for (auto& groupMember : group.Members)
{
_worldPacket >> groupMember.WarbandScenePlacementID;
_worldPacket >> groupMember.Type;
if (groupMember.Type == 0)
_worldPacket >> groupMember.Guid;
}
_worldPacket.ResetBitReader();
_worldPacket >> SizedString::BitsSize<9>(group.Name);
_worldPacket >> SizedString:
ata(group.Name);}
}
``` should be just this.... ``` uint32 memberCount;
_worldPacket >> memberCount;
Groups[i].Members.resize(memberCount);
that call like Groups[i].Members[j]. ``` looks sad
rektbyfaith
10-16-2025, 02:00 PM #12Archived author: moJIto_ice • Posted: 2025-10-16T14:00:25.100000+00:00
Original source
``` {
_worldPacket >> BitsSize<5>(Groups);
for (auto& group : Groups)
{
_worldPacket >> group.GroupID;
_worldPacket >> group.OrderIndex;
_worldPacket >> group.WarbandSceneID;
_worldPacket >> As<uint32>(group.Flags);
_worldPacket >> Size<uint32>(group.Members);
for (auto& groupMember : group.Members)
{
_worldPacket >> groupMember.WarbandScenePlacementID;
_worldPacket >> groupMember.Type;
if (groupMember.Type == 0)
_worldPacket >> groupMember.Guid;
}
_worldPacket.ResetBitReader();
_worldPacket >> SizedString::BitsSize<9>(group.Name);
_worldPacket >> SizedString:ata(group.Name);
}
}
``` should be just this.... ``` uint32 memberCount;
_worldPacket >> memberCount;
Groups[i].Members.resize(memberCount);
that call like Groups[i].Members[j]. ``` looks sad
Original source
Sorry for not being an C++ master
rektbyfaith
10-16-2025, 02:00 PM #13Archived author: Arwent • Posted: 2025-10-16T14:00:41.860000+00:00
Original source
Sorry for not being an C++ master
Original source
It works on my side, nobody implemented it, so
rektbyfaith
10-16-2025, 02:00 PM #14Archived author: Arwent • Posted: 2025-10-16T14:00:54.617000+00:00
Original source
It works on my side, nobody implemented it, so
Original source
<:joesmugshrug:1239547417532174388>
rektbyfaith
10-16-2025, 02:00 PM #15Archived author: Arwent • Posted: 2025-10-16T14:00:55.509000+00:00
Original source
<:joesmugshrug:1239547417532174388>
Original source
Just because it works on your side does not mean it's properly implemented
rektbyfaith
10-16-2025, 02:01 PM #16Archived author: MaxtorCoder • Posted: 2025-10-16T14:01:24.475000+00:00
Original source
Just because it works on your side does not mean it's properly implemented
Original source
FlushBits shouldnt be used in CMSG packets at server, also ``` uint8 nameLenDiv2;
_worldPacket >> nameLenDiv2;
uint32 nameLenMod2 = _worldPacket.ReadBits(1);
_worldPacket.FlushBits();
uint32 nameLen = (nameLenDiv2 * 2) + nameLenMod2;
Groups[i].Name = _worldPacket.ReadString(nameLen);``` totally wrong part
rektbyfaith
10-16-2025, 02:01 PM #17Archived author: moJIto_ice • Posted: 2025-10-16T14:01:29.434000+00:00
Original source
FlushBits shouldnt be used in CMSG packets at server, also ``` uint8 nameLenDiv2;
_worldPacket >> nameLenDiv2;
uint32 nameLenMod2 = _worldPacket.ReadBits(1);
_worldPacket.FlushBits();
uint32 nameLen = (nameLenDiv2 * 2) + nameLenMod2;
Groups[i].Name = _worldPacket.ReadString(nameLen);``` totally wrong part
Original source
What he has is fine tho, unless there is a ByteBuffer>> for Warbandgroup
rektbyfaith
10-16-2025, 02:01 PM #18Archived author: MaxtorCoder • Posted: 2025-10-16T14:01:38.244000+00:00
Original source
What he has is fine tho, unless there is a ByteBuffer>> for Warbandgroup
Original source
Didn't said that, but you're laughing af about what I've suggested
rektbyfaith
10-16-2025, 02:01 PM #19Archived author: Arwent • Posted: 2025-10-16T14:01:48.320000+00:00
Original source
Didn't said that, but you're laughing af about what I've suggested
Original source
I am not laughing, I was questionin my own sanity whether that was good or not.
rektbyfaith
10-16-2025, 02:02 PM #20Archived author: MaxtorCoder • Posted: 2025-10-16T14:02:09.328000+00:00
Original source
I am not laughing, I was questionin my own sanity whether that was good or not.
1 Guest(s)
1 Guest(s)