Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] Exactly, is there a special workflow/requirements to PR? Or just submit the change and wait for revi

[DiscordArchive] Exactly, is there a special workflow/requirements to PR? Or just submit the change and wait for revi

[DiscordArchive] Exactly, is there a special workflow/requirements to PR? Or just submit the change and wait for revi

rektbyfaith
Administrator
0
09-07-2025, 08:00 AM
#1
Archived author: RomanPerekrestov • Posted: 2025-09-07T08:00:02.564000+00:00
Original source

Exactly, is there a special workflow/requirements to PR? Or just submit the change and wait for review?
rektbyfaith
09-07-2025, 08:00 AM #1

Archived author: RomanPerekrestov • Posted: 2025-09-07T08:00:02.564000+00:00
Original source

Exactly, is there a special workflow/requirements to PR? Or just submit the change and wait for review?

rektbyfaith
Administrator
0
09-07-2025, 08:00 AM
#2
Archived author: Sicalicious • Posted: 2025-09-07T08:00:11.722000+00:00
Original source

Character db
rektbyfaith
09-07-2025, 08:00 AM #2

Archived author: Sicalicious • Posted: 2025-09-07T08:00:11.722000+00:00
Original source

Character db

rektbyfaith
Administrator
0
09-07-2025, 08:01 AM
#3
Archived author: ModoX • Posted: 2025-09-07T08:01:49.518000+00:00
Original source

In general:
1. Check if a related issue exists
2. Create pr, if issue exists note it in there
3. Wait for review
4. Be patient
5. Merge
rektbyfaith
09-07-2025, 08:01 AM #3

Archived author: ModoX • Posted: 2025-09-07T08:01:49.518000+00:00
Original source

In general:
1. Check if a related issue exists
2. Create pr, if issue exists note it in there
3. Wait for review
4. Be patient
5. Merge

rektbyfaith
Administrator
0
09-07-2025, 08:02 AM
#4
Archived author: ModoX • Posted: 2025-09-07T08:02:28.173000+00:00
Original source

(If no issue exists, you dont have to create an issue, but you can if you want to farm activity on github)
rektbyfaith
09-07-2025, 08:02 AM #4

Archived author: ModoX • Posted: 2025-09-07T08:02:28.173000+00:00
Original source

(If no issue exists, you dont have to create an issue, but you can if you want to farm activity on github)

rektbyfaith
Administrator
0
09-07-2025, 08:08 AM
#5
Archived author: RomanPerekrestov • Posted: 2025-09-07T08:08:22.950000+00:00
Original source

Thanks for explaining
rektbyfaith
09-07-2025, 08:08 AM #5

Archived author: RomanPerekrestov • Posted: 2025-09-07T08:08:22.950000+00:00
Original source

Thanks for explaining

rektbyfaith
Administrator
0
09-07-2025, 08:10 AM
#6
Archived author: ModoX • Posted: 2025-09-07T08:10:52.652000+00:00
Original source

Oh i forgot a step.
X. Dont feel personally attacked by feedback on the pr
rektbyfaith
09-07-2025, 08:10 AM #6

Archived author: ModoX • Posted: 2025-09-07T08:10:52.652000+00:00
Original source

Oh i forgot a step.
X. Dont feel personally attacked by feedback on the pr

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)