[DiscordArchive] what does it achieve?
[DiscordArchive] what does it achieve?
Original source
what does it achieve?
rektbyfaith
07-10-2025, 05:30 PM #1Archived author: Tea • Posted: 2025-07-10T17:30:49.567000+00:00
Original source
what does it achieve?
Original source
clarity and self-documentation (no first, second) and operator< keeps sorting logic local
rektbyfaith
07-10-2025, 05:33 PM #2Archived author: Telegrill • Posted: 2025-07-10T17:33:02.577000+00:00
Original source
clarity and self-documentation (no first, second) and operator< keeps sorting logic local
Original source
it'd scale better if the logic is reused across features at some point
rektbyfaith
07-10-2025, 05:35 PM #3Archived author: Telegrill • Posted: 2025-07-10T17:35:18.060000+00:00
Original source
it'd scale better if the logic is reused across features at some point
Original source
but thats the thing, it wont be reused, its just a local variable thats a implementation detail
rektbyfaith
07-10-2025, 05:35 PM #4Archived author: Tea • Posted: 2025-07-10T17:35:52.487000+00:00
Original source
but thats the thing, it wont be reused, its just a local variable thats a implementation detail
Original source
oh, well, in that case it'll leave it as it is
rektbyfaith
07-10-2025, 05:36 PM #5Archived author: Telegrill • Posted: 2025-07-10T17:36:14.455000+00:00
Original source
oh, well, in that case it'll leave it as it is
Original source
it's ready for re-review
rektbyfaith
07-10-2025, 05:36 PM #6Archived author: Telegrill • Posted: 2025-07-10T17:36:41.539000+00:00
Original source
it's ready for re-review
Original source
kill the optional arg, make it non-optional
rektbyfaith
07-10-2025, 05:37 PM #7Archived author: Tea • Posted: 2025-07-10T17:37:45.328000+00:00
Original source
kill the optional arg, make it non-optional
Original source
also kill GetPriorityRules and the enum
rektbyfaith
07-10-2025, 05:38 PM #8Archived author: Tea • Posted: 2025-07-10T17:38:05.286000+00:00
Original source
also kill GetPriorityRules and the enum
Original source
done
rektbyfaith
07-10-2025, 05:44 PM #9Archived author: Telegrill • Posted: 2025-07-10T17:44:04.954000+00:00
Original source
done
Original source
not sure if it's best to std::vector<PriorityRules> const& rules = priorityRules; or iterate through priorityRules directly
rektbyfaith
07-10-2025, 05:44 PM #10Archived author: Telegrill • Posted: 2025-07-10T17:44:58.143000+00:00
Original source
not sure if it's best to std::vector<PriorityRules> const& rules = priorityRules; or iterate through priorityRules directly