[DiscordArchive] <@200677690838220800> does it matter whether i push a PR for this without any way to know which one
[DiscordArchive] <@200677690838220800> does it matter whether i push a PR for this without any way to know which one
Original source
<@200677690838220800> does it matter whether i push a PR for this without any way to know which one is which?
rektbyfaith
06-30-2025, 05:47 PM #1Archived author: Telegrill • Posted: 2025-06-30T17:47:23.629000+00:00
Original source
<@200677690838220800> does it matter whether i push a PR for this without any way to know which one is which?
Original source
because sniffs aren't telling me much, unless there's something in the client i cant really access
rektbyfaith
06-30-2025, 05:48 PM #2Archived author: Telegrill • Posted: 2025-06-30T17:48:03.361000+00:00
Original source
because sniffs aren't telling me much, unless there's something in the client i cant really access
Original source
That a good thing, thanks for checking <:pepoLove:431878952265580564>
rektbyfaith
06-30-2025, 05:48 PM #3Archived author: Hayden • Posted: 2025-06-30T17:48:18.624000+00:00
Original source
That a good thing, thanks for checking <:pepoLove:431878952265580564>
Original source
or maybe there's something in sniffs im missing (which is probably true)
rektbyfaith
06-30-2025, 05:48 PM #4Archived author: Telegrill • Posted: 2025-06-30T17:48:25.485000+00:00
Original source
or maybe there's something in sniffs im missing (which is probably true)
Original source
since gear/tool shouldn't appear at all with one option set
rektbyfaith
06-30-2025, 05:48 PM #5Archived author: Telegrill • Posted: 2025-06-30T17:48:40.756000+00:00
Original source
since gear/tool shouldn't appear at all with one option set
Original source
I have a weird thing happening with AccountBankTabSettings, basically i want to update UFs after modify a tab so value taken by opcode CMSG_UPDATE_ACCOUNT_BANK_TAB_SETTINGS i'm doing something wrong? i got a malformed update
```C++
void WorldSession::HandleUpdateAccountBankTabSettings(WorldPackets::Bank::UpdateAccountBankTabSettings& p_Packet)
{
Creature* l_Unit = m_Player->GetNPCIfCanInteractWith(p_Packet.Banker, UNIT_NPC_FLAG_ACCOUNT_BANKER | UNIT_NPC_FLAG_BANKER, UNIT_NPC_FLAG2_NONE);
if (!l_Unit)
return;
if (m_Player->m_activePlayerData->AccountBankTabSettings.size() <= p_Packet.TabID)
return;
auto l_TabUpdate = m_Player->m_values.ModifyValue(&Player::m_activePlayerData).ModifyValue(&UF::ActivePlayerData::AccountBankTabSettings, p_Packet.TabID);
m_Player->SetUpdateFieldValue(l_TabUpdate.ModifyValue(&UF::BankTabSettings:
epositFlags), p_Packet.DepositFlags);m_Player->SetUpdateFieldValue(l_TabUpdate.ModifyValue(&UF::BankTabSettings::Name), p_Packet.Name);
m_Player->SetUpdateFieldValue(l_TabUpdate.ModifyValue(&UF::BankTabSettings::Icon), p_Packet.Icon);
m_Player->SetUpdateFieldValue(l_TabUpdate.ModifyValue(&UF::BankTabSettings:
escription), p_Packet.Description);```
![[Image: image.png?ex=690c37aa&is=690ae62a&hm=494...80b0c4fc4&]](https://cdn.discordapp.com/attachments/376457124726702080/1389302644081688687/image.png?ex=690c37aa&is=690ae62a&hm=494e69c4dc5e6da72d5d7d4b7cd63b097ee6402e84b83c2e2c3c26980b0c4fc4&)
rektbyfaith
06-30-2025, 05:52 PM #6Archived author: Hayden • Posted: 2025-06-30T17:52:42.401000+00:00
Original source
I have a weird thing happening with AccountBankTabSettings, basically i want to update UFs after modify a tab so value taken by opcode CMSG_UPDATE_ACCOUNT_BANK_TAB_SETTINGS i'm doing something wrong? i got a malformed update
```C++
void WorldSession::HandleUpdateAccountBankTabSettings(WorldPackets::Bank::UpdateAccountBankTabSettings& p_Packet)
{
Creature* l_Unit = m_Player->GetNPCIfCanInteractWith(p_Packet.Banker, UNIT_NPC_FLAG_ACCOUNT_BANKER | UNIT_NPC_FLAG_BANKER, UNIT_NPC_FLAG2_NONE);
if (!l_Unit)
return;
if (m_Player->m_activePlayerData->AccountBankTabSettings.size() <= p_Packet.TabID)
return;
auto l_TabUpdate = m_Player->m_values.ModifyValue(&Player::m_activePlayerData).ModifyValue(&UF::ActivePlayerData::AccountBankTabSettings, p_Packet.TabID);
m_Player->SetUpdateFieldValue(l_TabUpdate.ModifyValue(&UF::BankTabSettings:epositFlags), p_Packet.DepositFlags);
m_Player->SetUpdateFieldValue(l_TabUpdate.ModifyValue(&UF::BankTabSettings::Name), p_Packet.Name);
m_Player->SetUpdateFieldValue(l_TabUpdate.ModifyValue(&UF::BankTabSettings::Icon), p_Packet.Icon);
m_Player->SetUpdateFieldValue(l_TabUpdate.ModifyValue(&UF::BankTabSettings:escription), p_Packet.Description);
```
Original source
are you sure AccountBankTabSettings is not missing any new fields?
rektbyfaith
06-30-2025, 05:59 PM #7Archived author: Telegrill • Posted: 2025-06-30T17:59:34.345000+00:00
Original source
are you sure AccountBankTabSettings is not missing any new fields?
Original source
or the fields are in order
rektbyfaith
06-30-2025, 06:00 PM #8Archived author: Telegrill • Posted: 2025-06-30T18:00:12.196000+00:00
Original source
or the fields are in order
Original source
there is a bug with the structure specifically for accountbanktabsettings
rektbyfaith
06-30-2025, 06:00 PM #9Archived author: Tea • Posted: 2025-06-30T18:00:30.282000+00:00
Original source
there is a bug with the structure specifically for accountbanktabsettings
Original source
ha!
rektbyfaith
06-30-2025, 06:00 PM #10Archived author: Hayden • Posted: 2025-06-30T18:00:39.176000+00:00
Original source
ha!
1 Guest(s)
1 Guest(s)