[DiscordArchive] is it ok to rename GetAllMinionsByEntry to GetAllSummonsByEntry instead?
[DiscordArchive] is it ok to rename GetAllMinionsByEntry to GetAllSummonsByEntry instead?
Archived author: Telegrill • Posted: 2024-12-14T20:37:35.505000+00:00
Original source
is that even valid for master-branch anymore, though? current pet system is everyone using the same entryId for the summon creature with different displayId and beast spec
Archived author: Northstrider • Posted: 2024-12-14T20:37:58.865000+00:00
Original source
hunter pets are really just guardians with some extra stuff
Archived author: Telegrill • Posted: 2024-12-14T20:38:15.063000+00:00
Original source
well, talking about hunter pet in this case
Archived author: Northstrider • Posted: 2024-12-14T20:38:18.647000+00:00
Original source
no wait. guardian's are what we currently label as minion and Pets and Hunter Pets are more or less the same
Archived author: Northstrider • Posted: 2024-12-14T20:38:36.609000+00:00
Original source
ye, hunter pet is really just a summon with a nice extra api slapped on top of it
Archived author: Telegrill • Posted: 2024-12-14T20:39:11.928000+00:00
Original source
i mean, i get the decision of extending summoned creatures, all player-controlled or unit-controlled entities under the same structure to unify the logic and their AI handling in some way
Archived author: Telegrill • Posted: 2024-12-14T20:40:13.416000+00:00
Original source
especially because the distinction between summoned and controlled units kinda blurred as development went up and about
Archived author: Telegrill • Posted: 2024-12-14T20:40:29.311000+00:00
Original source
except very specific cases where Charm is just Charm
Archived author: Northstrider • Posted: 2024-12-14T20:40:45.053000+00:00
Original source
charm is also heavily abused at the moment
Archived author: Telegrill • Posted: 2024-12-14T20:42:52.654000+00:00
Original source
maybe at some point it would be wiser to just tell apart between CharmList (original ControlList) and extend SummonList for *any* (not any, just objects capable of having summons under them)