[DiscordArchive] is it ok to rename GetAllMinionsByEntry to GetAllSummonsByEntry instead?
[DiscordArchive] is it ok to rename GetAllMinionsByEntry to GetAllSummonsByEntry instead?
Original source
is it ok to rename GetAllMinionsByEntry to GetAllSummonsByEntry instead?
rektbyfaith
12-14-2024, 08:15 PM #1Archived author: Telegrill • Posted: 2024-12-14T20:15:06.624000+00:00
Original source
is it ok to rename GetAllMinionsByEntry to GetAllSummonsByEntry instead?
Original source
bit unsure why it was named as Minion on the first place if the helper iterates by checking IsSummon
rektbyfaith
12-14-2024, 08:15 PM #2Archived author: Telegrill • Posted: 2024-12-14T20:15:59.819000+00:00
Original source
bit unsure why it was named as Minion on the first place if the helper iterates by checking IsSummon
Original source
No because GetAllMinions only returns all summons which have been registered as minion. Not all summons are minions. Only those who have been directly linked to the player via Unit::SetMinion
rektbyfaith
12-14-2024, 08:18 PM #3Archived author: Northstrider • Posted: 2024-12-14T20:18:12.206000+00:00
Original source
No because GetAllMinions only returns all summons which have been registered as minion. Not all summons are minions. Only those who have been directly linked to the player via Unit::SetMinion
Original source
while I agree that this sounds weird, there is no tracking for ALL summons as of right now
rektbyfaith
12-14-2024, 08:18 PM #4Archived author: Northstrider • Posted: 2024-12-14T20:18:42.710000+00:00
Original source
while I agree that this sounds weird, there is no tracking for ALL summons as of right now
Original source
that's why I'm wondering, I want to decluter this mess
rektbyfaith
12-14-2024, 08:19 PM #5Archived author: Telegrill • Posted: 2024-12-14T20:19:08.627000+00:00
Original source
that's why I'm wondering, I want to decluter this mess
Original source
this is a fundamental design flaw of the summon system right now. if you 'declutter' it, you can and will break a ton of stuff
rektbyfaith
12-14-2024, 08:19 PM #6Archived author: Northstrider • Posted: 2024-12-14T20:19:34.507000+00:00
Original source
this is a fundamental design flaw of the summon system right now. if you 'declutter' it, you can and will break a ton of stuff
Original source
(been there, done that)
rektbyfaith
12-14-2024, 08:19 PM #7Archived author: Northstrider • Posted: 2024-12-14T20:19:53.354000+00:00
Original source
(been there, done that)
Original source
https://github.com/The-Cataclysm-Preserv...e5974a4df7
rektbyfaith
12-14-2024, 08:20 PM #8Archived author: Northstrider • Posted: 2024-12-14T20:20:27.546000+00:00
Original source
https://github.com/The-Cataclysm-Preserv...e5974a4df7
Original source
but IsSummon only checks for UNIT_MASK_SUMMON which is inheritely set once the creature is TempSummon
rektbyfaith
12-14-2024, 08:20 PM #9Archived author: Telegrill • Posted: 2024-12-14T20:20:42.530000+00:00
Original source
but IsSummon only checks for UNIT_MASK_SUMMON which is inheritely set once the creature is TempSummon
Original source
or that's what I'm reading on the constructor at lesat
rektbyfaith
12-14-2024, 08:21 PM #10Archived author: Telegrill • Posted: 2024-12-14T20:21:01.641000+00:00
Original source
or that's what I'm reading on the constructor at lesat
1 Guest(s)
1 Guest(s)