[DiscordArchive] <@216234897390436353> is there already some WIP on that quest? that I can use to maybe finish it?
[DiscordArchive] <@216234897390436353> is there already some WIP on that quest? that I can use to maybe finish it?
Archived author: martijnh • Posted: 2024-10-06T13:04:11.853000+00:00
Original source
<@216234897390436353> is there already some WIP on that quest? that I can use to maybe finish it?
Archived author: martijnh • Posted: 2024-10-06T13:05:29.971000+00:00
Original source
I just tried to set NextQuestID for Bjorn as such that Alaria will continue:
UPDATE quest_template_addon
SET NextQuestID = 55639
WHERE id=55965;
But alaria is not giving me that quest (She is not showing the ! )
Archived author: ModoX • Posted: 2024-10-06T13:11:26.845000+00:00
Original source
It involves a new system "spawntracking" which we have a pr for, but is not merged yet
Archived author: martijnh • Posted: 2024-10-06T13:12:47.027000+00:00
Original source
Aha understand.. WHy are there so many PR's ? Isnt that like bad practice?
Archived author: martijnh • Posted: 2024-10-06T13:13:01.984000+00:00
Original source
merge-conflict wise
Archived author: ModoX • Posted: 2024-10-06T13:15:43.899000+00:00
Original source
The purpose of prs are that anyone can provide code and the maintainers can review it before its merged. That prevents "bad code" being merged
Archived author: ModoX • Posted: 2024-10-06T13:17:05.089000+00:00
Original source
Also keep in mind that the maintainers are doing it in their free time and not as a full time job
Archived author: martijnh • Posted: 2024-10-06T13:17:13.539000+00:00
Original source
Trying resolve merge conflicts can result in worser code than was intended i remember.
Archived author: martijnh • Posted: 2024-10-06T13:19:02.998000+00:00
Original source
Maybe allowing some bad code would not be that bad? many stuff is not working anyway.
Maintainers can always refactor afterwards I would assume.
But the benifit is that ppl can work on more stuff..
Maintainers can now also think.. that other developers like me..are not eager to assist in their free time, because of all the potential work already done..
Archived author: martijnh • Posted: 2024-10-06T13:20:10.105000+00:00
Original source
again: I was eager to fix that quest.. But now that I learn there are so many PR's I am not going to