[DiscordArchive] <@216234897390436353> is there already some WIP on that quest? that I can use to maybe finish it?
[DiscordArchive] <@216234897390436353> is there already some WIP on that quest? that I can use to maybe finish it?
Original source
"Some bad code" is allowed sure, but still review process has to happen. "Maintainers can refactor it later", i mean why not implement it the right way as far as research allows directly? I mean we dont have deadlines here.
Also you might wanna keep in mind that bigger projects like any microsoft or google project has way more prs. PR amount is kinda one metric of many for activity.
There were quite a few forks which merged every pr without review which pretty much all died
rektbyfaith
10-06-2024, 01:30 PM #11Archived author: ModoX • Posted: 2024-10-06T13:30:09.337000+00:00
Original source
"Some bad code" is allowed sure, but still review process has to happen. "Maintainers can refactor it later", i mean why not implement it the right way as far as research allows directly? I mean we dont have deadlines here.
Also you might wanna keep in mind that bigger projects like any microsoft or google project has way more prs. PR amount is kinda one metric of many for activity.
There were quite a few forks which merged every pr without review which pretty much all died
Original source
are you mdX7 ?
rektbyfaith
10-06-2024, 01:30 PM #12Archived author: martijnh • Posted: 2024-10-06T13:30:25.475000+00:00
Original source
are you mdX7 ?
Original source
And if we're too slow you're still free to fork, our license allows that
rektbyfaith
10-06-2024, 01:30 PM #13Archived author: ModoX • Posted: 2024-10-06T13:30:28.689000+00:00
Original source
And if we're too slow you're still free to fork, our license allows that
Original source
Yes
rektbyfaith
10-06-2024, 01:30 PM #14Archived author: ModoX • Posted: 2024-10-06T13:30:41.842000+00:00
Original source
Yes
Original source
I see a very ncie PR from you from 2021 or 2022.. Clean code.
rektbyfaith
10-06-2024, 01:31 PM #15Archived author: martijnh • Posted: 2024-10-06T13:31:03.022000+00:00
Original source
I see a very ncie PR from you from 2021 or 2022.. Clean code.
Original source
Core/SAI: added possibility to add targets of CREATE_CONVERSATION
rektbyfaith
10-06-2024, 01:31 PM #16Archived author: martijnh • Posted: 2024-10-06T13:31:27.083000+00:00
Original source
Core/SAI: added possibility to add targets of CREATE_CONVERSATION
Original source
You are missing almost 3 years of ppl using that change and maybe finding/developing improvements on your changes.. and/or fix other issues using your solve.
This because the reviewers have a few years of ?
rektbyfaith
10-06-2024, 01:33 PM #17Archived author: martijnh • Posted: 2024-10-06T13:33:14.642000+00:00
Original source
You are missing almost 3 years of ppl using that change and maybe finding/developing improvements on your changes.. and/or fix other issues using your solve.
This because the reviewers have a few years of ?
Original source
Let us not compare Google with TC though
rektbyfaith
10-06-2024, 01:33 PM #18Archived author: martijnh • Posted: 2024-10-06T13:33:51.740000+00:00
Original source
Let us not compare Google with TC though
Original source
there was a reason why i didnt merge it, but i dont recall what it was; let me check how i implemented the quest i initially did it for
rektbyfaith
10-06-2024, 01:34 PM #19Archived author: ModoX • Posted: 2024-10-06T13:34:47.274000+00:00
Original source
there was a reason why i didnt merge it, but i dont recall what it was; let me check how i implemented the quest i initially did it for
Original source
that would be the fact that its trying to make something SAI wasnt really designed to do (have two sets of targets)
rektbyfaith
10-06-2024, 01:35 PM #20Archived author: Tea • Posted: 2024-10-06T13:35:19.145000+00:00
Original source
that would be the fact that its trying to make something SAI wasnt really designed to do (have two sets of targets)
1 Guest(s)
1 Guest(s)