[DiscordArchive] why do you work on selling TC repacks with Thordekk then?
[DiscordArchive] why do you work on selling TC repacks with Thordekk then?
Archived author: ModoX • Posted: 2023-09-18T00:32:00.661000+00:00
Original source
thats a kinda wrong approach you are thinking here
Archived author: ModoX • Posted: 2023-09-18T00:32:50.427000+00:00
Original source
the review process is there for a reason, so you may become better at stuff and that the code is maintainable
Archived author: ModoX • Posted: 2023-09-18T00:33:10.511000+00:00
Original source
and with the next pr after that you might remember what u did wrong in previous, what you could do better [...]
Archived author: Fluxurion • Posted: 2023-09-18T00:33:11.501000+00:00
Original source
Yeah understandable
Archived author: ZaDarkSide • Posted: 2023-09-18T00:33:16.850000+00:00
Original source
you could contribute to TC instead even if the code isn't perfect
Archived author: ModoX • Posted: 2023-09-18T00:33:44.197000+00:00
Original source
also dont think theres just a "one way" approach for everything, there are always multiple ways
Archived author: ModoX • Posted: 2023-09-18T00:34:53.736000+00:00
Original source
scenario: your code works perfectly well from player view, but is terribly bad for server performance, it would then be adjusted by related maintainer whos reviewing it to his best knowledge, then explained to pr creator and merged
Archived author: ModoX • Posted: 2023-09-18T00:36:39.286000+00:00
Original source
and if theres some complicated thing (think of that dracthyr map bug you had with your last pr) there are people trying to help. At the end of the day we were like 4-5 people who were working on fixing that bug, just for your pr
Archived author: ZaDarkSide • Posted: 2023-09-18T00:37:19.882000+00:00
Original source
you only worked on p-server features like battlepay, character boost, solocraft, i wonder why
Archived author: Fluxurion • Posted: 2023-09-18T00:38:33.072000+00:00
Original source
Using xts as currency and rewarding xts for playing time