[DiscordArchive] https://github.com/TrinityCore/TrinityCore/commit/d6133c78de9e2272765c2cfda82c440663acd254#diff-b4a2
[DiscordArchive] https://github.com/TrinityCore/TrinityCore/commit/d6133c78de9e2272765c2cfda82c440663acd254#diff-b4a2
Original source
https://github.com/TrinityCore/TrinityCo...02c6R13368
<@151344107623546880> shouldn't here be just `SetHoverHeight(hoverHeight);` because `hoverHeight` already is defined at the start of the function with `float hoverHeight = DEFAULT_PLAYER_HOVER_HEIGHT;` so there is isn't a need for an extra check if it exists?
rektbyfaith
04-12-2023, 10:01 AM #1Archived author: ZaDarkSide • Posted: 2023-04-12T10:01:39.260000+00:00
Original source
https://github.com/TrinityCore/TrinityCo...02c6R13368
<@151344107623546880> shouldn't here be just `SetHoverHeight(hoverHeight);` because `hoverHeight` already is defined at the start of the function with `float hoverHeight = DEFAULT_PLAYER_HOVER_HEIGHT;` so there is isn't a need for an extra check if it exists?
Original source
<@429055059754483713> it can become 0 after init due to reassignment few lines below init using db2 data. On retail they are falling back to default hoverheight in such case
rektbyfaith
04-12-2023, 10:15 AM #2Archived author: ModoX • Posted: 2023-04-12T10:15:38.613000+00:00
Original source
<@429055059754483713> it can become 0 after init due to reassignment few lines below init using db2 data. On retail they are falling back to default hoverheight in such case
Original source
thanks for the explanation
rektbyfaith
04-12-2023, 10:17 AM #3Archived author: ZaDarkSide • Posted: 2023-04-12T10:17:04.124000+00:00
Original source
thanks for the explanation
Original source
basically this can be 0 if any of them are 0 `hoverHeight = modelData.HoverHeight * modelData.ModelScale * displayInfo.CreatureModelScale * displayScale`
rektbyfaith
04-12-2023, 10:17 AM #4Archived author: ZaDarkSide • Posted: 2023-04-12T10:17:51.120000+00:00
Original source
basically this can be 0 if any of them are 0 `hoverHeight = modelData.HoverHeight * modelData.ModelScale * displayInfo.CreatureModelScale * displayScale`
Original source
Yep
rektbyfaith
04-12-2023, 10:18 AM #5Archived author: ModoX • Posted: 2023-04-12T10:18:18.522000+00:00
Original source
Yep
Original source
i think I was trusting db2 data way too much
rektbyfaith
04-12-2023, 10:18 AM #6Archived author: ZaDarkSide • Posted: 2023-04-12T10:18:19.421000+00:00
Original source
i think I was trusting db2 data way too much
Original source
Thats not really about trust, more about blizz being too lazy to fill the hoverheight fields for models which never hover
rektbyfaith
04-12-2023, 10:19 AM #7Archived author: ModoX • Posted: 2023-04-12T10:19:32.383000+00:00
Original source
Thats not really about trust, more about blizz being too lazy to fill the hoverheight fields for models which never hover
Original source
kinda makes sense thx
rektbyfaith
04-12-2023, 10:26 AM #8Archived author: ZaDarkSide • Posted: 2023-04-12T10:26:25.718000+00:00
Original source
kinda makes sense thx
Original source
<@216234897390436353> shouldn't be `SetHoverHeight(hoverHeight > 0.0f ? hoverHeight : DEFAULT_PLAYER_HOVER_HEIGHT);` a much better check? floats can be negative too right?
rektbyfaith
04-12-2023, 10:34 AM #9Archived author: ZaDarkSide • Posted: 2023-04-12T10:34:03.022000+00:00
Original source
<@216234897390436353> shouldn't be `SetHoverHeight(hoverHeight > 0.0f ? hoverHeight : DEFAULT_PLAYER_HOVER_HEIGHT);` a much better check? floats can be negative too right?
Original source
Floats can be negative, yes. But negative hoverheight is a thing according to research
rektbyfaith
04-12-2023, 10:36 AM #10Archived author: ModoX • Posted: 2023-04-12T10:36:13.992000+00:00
Original source
Floats can be negative, yes. But negative hoverheight is a thing according to research
1 Guest(s)
1 Guest(s)