Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] this screen was from classic?

[DiscordArchive] this screen was from classic?

[DiscordArchive] this screen was from classic?

Pages (2): Previous 1 2
rektbyfaith
Administrator
0
03-13-2023, 09:51 PM
#11
Archived author: Seyden • Posted: 2023-03-13T21:51:11.357000+00:00
Original source

ye indeed, but ye afair that wasn't the case in previous xpacs
rektbyfaith
03-13-2023, 09:51 PM #11

Archived author: Seyden • Posted: 2023-03-13T21:51:11.357000+00:00
Original source

ye indeed, but ye afair that wasn't the case in previous xpacs

rektbyfaith
Administrator
0
03-13-2023, 09:54 PM
#12
Archived author: Deleted User • Posted: 2023-03-13T21:54:03.779000+00:00
Original source

so when i look at your patches, there are some instructions you don't execute, but they look superfluous. i.e. in this picture, green is the actual execution flow, red is your execution flow (result is the same, but the jumps are different), where that *f0e1 instruction is normally `jb short near ptr loc_14023F0EB+2` before the jmp patch
[Image: image.png?ex=690c703b&is=690b1ebb&hm=1bf...05153cf26&]
rektbyfaith
03-13-2023, 09:54 PM #12

Archived author: Deleted User • Posted: 2023-03-13T21:54:03.779000+00:00
Original source

so when i look at your patches, there are some instructions you don't execute, but they look superfluous. i.e. in this picture, green is the actual execution flow, red is your execution flow (result is the same, but the jumps are different), where that *f0e1 instruction is normally `jb short near ptr loc_14023F0EB+2` before the jmp patch
[Image: image.png?ex=690c703b&is=690b1ebb&hm=1bf...05153cf26&]

rektbyfaith
Administrator
0
03-13-2023, 09:59 PM
#13
Archived author: Fabian • Posted: 2023-03-13T21:59:05.350000+00:00
Original source

it doesn’t matter which one you execute (sometimes)
rektbyfaith
03-13-2023, 09:59 PM #13

Archived author: Fabian • Posted: 2023-03-13T21:59:05.350000+00:00
Original source

it doesn’t matter which one you execute (sometimes)

rektbyfaith
Administrator
0
03-13-2023, 09:59 PM
#14
Archived author: Fabian • Posted: 2023-03-13T21:59:26.927000+00:00
Original source

however executing the first jmp will ALWAYS be correct
rektbyfaith
03-13-2023, 09:59 PM #14

Archived author: Fabian • Posted: 2023-03-13T21:59:26.927000+00:00
Original source

however executing the first jmp will ALWAYS be correct

rektbyfaith
Administrator
0
03-13-2023, 09:59 PM
#15
Archived author: Fabian • Posted: 2023-03-13T21:59:46.897000+00:00
Original source

the 2nd one will sometimes jump into trash
rektbyfaith
03-13-2023, 09:59 PM #15

Archived author: Fabian • Posted: 2023-03-13T21:59:46.897000+00:00
Original source

the 2nd one will sometimes jump into trash

Pages (2): Previous 1 2
Recently Browsing
 
Recently Browsing