[DiscordArchive] Hey <@200677690838220800> , little issue I ran into and I'd like other opinions :
[DiscordArchive] Hey <@200677690838220800> , little issue I ran into and I'd like other opinions :
Original source
Hey <@200677690838220800> , little issue I ran into and I'd like other opinions :
in bool Spell::UpdateChanneledTargetList()
we create a local variable channelAuraMask which contains all the effects of type AURA of the spell
but when verifying 20 lines later (in the for (TargetInfo& targetInfo : m_UniqueTargetInfo)) loop)
we verify that we have valid target for all effects contained in local variable channelTargetEffectMask (which is a copy of Spell::m_channelTargetEffectMask).
thing is Spell::m_channelTargetEffectMask contains all effects of the spell that Hit, including non-aura (hence non-channeled) ones.
So I encounter the issue with this spell : Sanitizing Cycle - 346766 (http://wowhead.com/spell=346766)
if any of the effect (including EFFECT_2 and EFFECT_3) at any point no longer has any of its target, all the channel gets canceled.
I found it because EFFECT_2 targets only 1 unit, more or less at random, so depending on what's targeted, it randomly breaks the channel of the boss.
For me it doesn't make sense to check non-channeled effect targets to validate continuing the channel of the spell, what do you think ?
[Embed: Sanitizing Cycle]
Hylbrande channels titan power from the chamber to purge all unauthorized life forms, inflicting 6582 Holy damage every 1.5 sec to all players who stand in the Sanitizing Field.
http://wowhead.com/spell=346766
rektbyfaith
05-11-2022, 12:08 PM #1Archived author: Hayden • Posted: 2022-05-11T12:08:03.875000+00:00
Original source
Hey <@200677690838220800> , little issue I ran into and I'd like other opinions :
in bool Spell::UpdateChanneledTargetList()
we create a local variable channelAuraMask which contains all the effects of type AURA of the spell
but when verifying 20 lines later (in the for (TargetInfo& targetInfo : m_UniqueTargetInfo)) loop)
we verify that we have valid target for all effects contained in local variable channelTargetEffectMask (which is a copy of Spell::m_channelTargetEffectMask).
thing is Spell::m_channelTargetEffectMask contains all effects of the spell that Hit, including non-aura (hence non-channeled) ones.
So I encounter the issue with this spell : Sanitizing Cycle - 346766 (http://wowhead.com/spell=346766)
if any of the effect (including EFFECT_2 and EFFECT_3) at any point no longer has any of its target, all the channel gets canceled.
I found it because EFFECT_2 targets only 1 unit, more or less at random, so depending on what's targeted, it randomly breaks the channel of the boss.
For me it doesn't make sense to check non-channeled effect targets to validate continuing the channel of the spell, what do you think ?
[Embed: Sanitizing Cycle]
Hylbrande channels titan power from the chamber to purge all unauthorized life forms, inflicting 6582 Holy damage every 1.5 sec to all players who stand in the Sanitizing Field.
http://wowhead.com/spell=346766
Original source
thats not quite true
rektbyfaith
05-11-2022, 12:37 PM #2Archived author: Tea • Posted: 2022-05-11T12:37:22.572000+00:00
Original source
thats not quite true
Original source
it doesnt make sense for the spell you just linked
rektbyfaith
05-11-2022, 12:37 PM #3Archived author: Tea • Posted: 2022-05-11T12:37:53.766000+00:00
Original source
it doesnt make sense for the spell you just linked
Original source
there are non-aura channeled spells
rektbyfaith
05-11-2022, 12:39 PM #4Archived author: Tea • Posted: 2022-05-11T12:39:50.896000+00:00
Original source
there are non-aura channeled spells
Original source
There was a mixup between effects, the single-target effect that fucks things up is EFFECT_3, not 2,
but I don't see how it doesn't make sense here
rektbyfaith
05-11-2022, 12:41 PM #5Archived author: Zhalfyr • Posted: 2022-05-11T12:41:26.731000+00:00
Original source
There was a mixup between effects, the single-target effect that fucks things up is EFFECT_3, not 2,
but I don't see how it doesn't make sense here
1 Guest(s)
1 Guest(s)