[DiscordArchive] what static analysis tools are you running?
[DiscordArchive] what static analysis tools are you running?
Original source
so old code gets to live
rektbyfaith
08-19-2025, 11:48 AM #21Archived author: Tea • Posted: 2025-08-19T11:48:21.280000+00:00
Original source
so old code gets to live
Original source
but new code should not be written in the old way
rektbyfaith
08-19-2025, 11:48 AM #22Archived author: Tea • Posted: 2025-08-19T11:48:32.474000+00:00
Original source
but new code should not be written in the old way
Original source
Because people feedback in PRs very blunt and to the point. That's not trying to be rude, it's just how we operate in the industry. No need to waste time on pleasantries. If I'm reviewing a juniors PR at work and it has some problems, I will start with encouraging them and saying what a great job they've done so far. Then give them a huge list of things to look at / consider.
rektbyfaith
08-19-2025, 12:10 PM #23Archived author: stoneharry • Posted: 2025-08-19T12:10:19.490000+00:00
Original source
Because people feedback in PRs very blunt and to the point. That's not trying to be rude, it's just how we operate in the industry. No need to waste time on pleasantries. If I'm reviewing a juniors PR at work and it has some problems, I will start with encouraging them and saying what a great job they've done so far. Then give them a huge list of things to look at / consider.
1 Guest(s)
1 Guest(s)