Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] Is a generic core addition for 3.3.5a generally compatibile with master? If I want to add the gm com

[DiscordArchive] Is a generic core addition for 3.3.5a generally compatibile with master? If I want to add the gm com

[DiscordArchive] Is a generic core addition for 3.3.5a generally compatibile with master? If I want to add the gm com

Pages (2): 1 2 Next
rektbyfaith
Administrator
0
08-08-2025, 06:02 PM
#1
Archived author: JudgeFae • Posted: 2025-08-08T18:02:55.064000+00:00
Original source

Is a generic core addition for 3.3.5a generally compatibile with master? If I want to add the gm command from azeroth core ".bags clear" to trinity could it be added to most TC branches?
rektbyfaith
08-08-2025, 06:02 PM #1

Archived author: JudgeFae • Posted: 2025-08-08T18:02:55.064000+00:00
Original source

Is a generic core addition for 3.3.5a generally compatibile with master? If I want to add the gm command from azeroth core ".bags clear" to trinity could it be added to most TC branches?

rektbyfaith
Administrator
0
08-08-2025, 06:05 PM
#2
Archived author: jackpoz • Posted: 2025-08-08T18:05:41.837000+00:00
Original source

We accept prs only from the original authors of code changes btw
rektbyfaith
08-08-2025, 06:05 PM #2

Archived author: jackpoz • Posted: 2025-08-08T18:05:41.837000+00:00
Original source

We accept prs only from the original authors of code changes btw

rektbyfaith
Administrator
0
08-08-2025, 06:06 PM
#3
Archived author: JudgeFae • Posted: 2025-08-08T18:06:18.193000+00:00
Original source

Any port probably won't be 1:1 so I'd be more of a co-author?
rektbyfaith
08-08-2025, 06:06 PM #3

Archived author: JudgeFae • Posted: 2025-08-08T18:06:18.193000+00:00
Original source

Any port probably won't be 1:1 so I'd be more of a co-author?

rektbyfaith
Administrator
0
08-08-2025, 06:06 PM
#4
Archived author: JudgeFae • Posted: 2025-08-08T18:06:39.021000+00:00
Original source

But will keep that in mind and might find and pester whoever wrote the original
rektbyfaith
08-08-2025, 06:06 PM #4

Archived author: JudgeFae • Posted: 2025-08-08T18:06:39.021000+00:00
Original source

But will keep that in mind and might find and pester whoever wrote the original

rektbyfaith
Administrator
0
08-08-2025, 06:09 PM
#5
Archived author: stoneharry • Posted: 2025-08-08T18:09:39.394000+00:00
Original source

Oh absolutely. There are a myriad of reasons why some of the code sucks. So many people have worked on it, and software changes a lot in a few years let alone 20. And open source devs are working on it out of their own passion, it's not a paid job.

The code is not bad for performance
rektbyfaith
08-08-2025, 06:09 PM #5

Archived author: stoneharry • Posted: 2025-08-08T18:09:39.394000+00:00
Original source

Oh absolutely. There are a myriad of reasons why some of the code sucks. So many people have worked on it, and software changes a lot in a few years let alone 20. And open source devs are working on it out of their own passion, it's not a paid job.

The code is not bad for performance

rektbyfaith
Administrator
0
08-08-2025, 06:09 PM
#6
Archived author: jackpoz • Posted: 2025-08-08T18:09:57.307000+00:00
Original source

You would have to implement the feature without looking at the code of the fork
rektbyfaith
08-08-2025, 06:09 PM #6

Archived author: jackpoz • Posted: 2025-08-08T18:09:57.307000+00:00
Original source

You would have to implement the feature without looking at the code of the fork

rektbyfaith
Administrator
0
08-08-2025, 06:10 PM
#7
Archived author: JudgeFae • Posted: 2025-08-08T18:10:19.415000+00:00
Original source

I could do something like that. Can't guartntee it would be exceptionally good
rektbyfaith
08-08-2025, 06:10 PM #7

Archived author: JudgeFae • Posted: 2025-08-08T18:10:19.415000+00:00
Original source

I could do something like that. Can't guartntee it would be exceptionally good

rektbyfaith
Administrator
0
08-08-2025, 06:10 PM
#8
Archived author: JudgeFae • Posted: 2025-08-08T18:10:26.708000+00:00
Original source

I just like the feature
rektbyfaith
08-08-2025, 06:10 PM #8

Archived author: JudgeFae • Posted: 2025-08-08T18:10:26.708000+00:00
Original source

I just like the feature

rektbyfaith
Administrator
0
08-08-2025, 06:10 PM
#9
Archived author: JudgeFae • Posted: 2025-08-08T18:10:42.699000+00:00
Original source

But you're right the whole file is encoded with AC copyright
rektbyfaith
08-08-2025, 06:10 PM #9

Archived author: JudgeFae • Posted: 2025-08-08T18:10:42.699000+00:00
Original source

But you're right the whole file is encoded with AC copyright

rektbyfaith
Administrator
0
08-08-2025, 06:11 PM
#10
Archived author: Northstrider • Posted: 2025-08-08T18:11:09.901000+00:00
Original source

which would be a good reason for you to try to write a own version
rektbyfaith
08-08-2025, 06:11 PM #10

Archived author: Northstrider • Posted: 2025-08-08T18:11:09.901000+00:00
Original source

which would be a good reason for you to try to write a own version

Pages (2): 1 2 Next
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)