Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] What about from the sniffs ?

[DiscordArchive] What about from the sniffs ?

[DiscordArchive] What about from the sniffs ?

Pages (2): Previous 1 2
rektbyfaith
Administrator
0
07-23-2025, 12:06 PM
#11
Archived author: Crane • Posted: 2025-07-23T12:06:46.471000+00:00
Original source

That's why I'm not submitting any PRs because I know they'd all be rejected anyway, which is your right as the owner. But be that as it may, there are certainly enough people interested in my fix, even if they only install it as a temporary fix.
Ultimately, everyone has to decide for themselves; it's all open source, and anyone can tweak the code as they please
rektbyfaith
07-23-2025, 12:06 PM #11

Archived author: Crane • Posted: 2025-07-23T12:06:46.471000+00:00
Original source

That's why I'm not submitting any PRs because I know they'd all be rejected anyway, which is your right as the owner. But be that as it may, there are certainly enough people interested in my fix, even if they only install it as a temporary fix.
Ultimately, everyone has to decide for themselves; it's all open source, and anyone can tweak the code as they please

rektbyfaith
Administrator
0
07-23-2025, 12:29 PM
#12
Archived author: Crane • Posted: 2025-07-23T12:29:46.868000+00:00
Original source

If you still want to take a look, I can post the code and if not, that's ok too ^^
rektbyfaith
07-23-2025, 12:29 PM #12

Archived author: Crane • Posted: 2025-07-23T12:29:46.868000+00:00
Original source

If you still want to take a look, I can post the code and if not, that's ok too ^^

rektbyfaith
Administrator
0
07-23-2025, 12:30 PM
#13
Archived author: jackpoz • Posted: 2025-07-23T12:30:20.720000+00:00
Original source

you can open a PR so who is interested can get the changes too
rektbyfaith
07-23-2025, 12:30 PM #13

Archived author: jackpoz • Posted: 2025-07-23T12:30:20.720000+00:00
Original source

you can open a PR so who is interested can get the changes too

rektbyfaith
Administrator
0
07-23-2025, 12:30 PM
#14
Archived author: Tea • Posted: 2025-07-23T12:30:56.965000+00:00
Original source

uh, no
rektbyfaith
07-23-2025, 12:30 PM #14

Archived author: Tea • Posted: 2025-07-23T12:30:56.965000+00:00
Original source

uh, no

rektbyfaith
Administrator
0
07-23-2025, 12:31 PM
#15
Archived author: Tea • Posted: 2025-07-23T12:31:09.140000+00:00
Original source

dont tell people to open prs that we said will not be accepted
rektbyfaith
07-23-2025, 12:31 PM #15

Archived author: Tea • Posted: 2025-07-23T12:31:09.140000+00:00
Original source

dont tell people to open prs that we said will not be accepted

rektbyfaith
Administrator
0
07-23-2025, 12:32 PM
#16
Archived author: jackpoz • Posted: 2025-07-23T12:32:04.483000+00:00
Original source

it's an easy way to share the code, easier than on discord
rektbyfaith
07-23-2025, 12:32 PM #16

Archived author: jackpoz • Posted: 2025-07-23T12:32:04.483000+00:00
Original source

it's an easy way to share the code, easier than on discord

rektbyfaith
Administrator
0
07-23-2025, 12:32 PM
#17
Archived author: Crane • Posted: 2025-07-23T12:32:52.916000+00:00
Original source

You can take a look and if you don't like it you can always reject it
rektbyfaith
07-23-2025, 12:32 PM #17

Archived author: Crane • Posted: 2025-07-23T12:32:52.916000+00:00
Original source

You can take a look and if you don't like it you can always reject it

rektbyfaith
Administrator
0
07-23-2025, 12:33 PM
#18
Archived author: Tea • Posted: 2025-07-23T12:33:40.243000+00:00
Original source

thats nice of you but most people get real butthurt when we reject their prs
rektbyfaith
07-23-2025, 12:33 PM #18

Archived author: Tea • Posted: 2025-07-23T12:33:40.243000+00:00
Original source

thats nice of you but most people get real butthurt when we reject their prs

rektbyfaith
Administrator
0
07-23-2025, 12:35 PM
#19
Archived author: Crane • Posted: 2025-07-23T12:35:59.675000+00:00
Original source

I don't have a problem with that; I keep it to myself, or if people DM me and are interested, I'll give it to them.

But you can give people a chance and take a look; it doesn't hurt and it doesn't cost anything.
rektbyfaith
07-23-2025, 12:35 PM #19

Archived author: Crane • Posted: 2025-07-23T12:35:59.675000+00:00
Original source

I don't have a problem with that; I keep it to myself, or if people DM me and are interested, I'll give it to them.

But you can give people a chance and take a look; it doesn't hurt and it doesn't cost anything.

rektbyfaith
Administrator
0
07-23-2025, 12:37 PM
#20
Archived author: Crane • Posted: 2025-07-23T12:37:14.624000+00:00
Original source

but a PR from my fork wouldn't work anyway
rektbyfaith
07-23-2025, 12:37 PM #20

Archived author: Crane • Posted: 2025-07-23T12:37:14.624000+00:00
Original source

but a PR from my fork wouldn't work anyway

Pages (2): Previous 1 2
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)