Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] shouldnt that pass the reference loot tables instead?

[DiscordArchive] shouldnt that pass the reference loot tables instead?

[DiscordArchive] shouldnt that pass the reference loot tables instead?

Pages (2): 1 2 Next
rektbyfaith
Administrator
Find
0
07-07-2025, 05:53 PM
#1
Archived author: robinsch • Posted: 2025-07-07T17:53:24.329000+00:00
Original source

shouldnt that pass the reference loot tables instead?
Reply
Reply
rektbyfaith
07-07-2025, 05:53 PM #1

Archived author: robinsch • Posted: 2025-07-07T17:53:24.329000+00:00
Original source

shouldnt that pass the reference loot tables instead?

Reply
Reply
rektbyfaith
Administrator
Find
0
07-07-2025, 05:56 PM
#2
Archived author: Tea • Posted: 2025-07-07T17:56:02.617000+00:00
Original source

well rip git blame
Reply
Reply
rektbyfaith
07-07-2025, 05:56 PM #2

Archived author: Tea • Posted: 2025-07-07T17:56:02.617000+00:00
Original source

well rip git blame

Reply
Reply
rektbyfaith
Administrator
Find
0
07-07-2025, 05:56 PM
#3
Archived author: Tea • Posted: 2025-07-07T17:56:21.229000+00:00
Original source

Author: Neo2003 <none@none>
Date: 17 years ago (2.10.2008 23:23:55)
Commit hash: 9b1c0e006f20091f28f3f468cfcab1feb51286bd
Child: 2265aef9

[svn] * Proper SVN structure
Reply
Reply
rektbyfaith
07-07-2025, 05:56 PM #3

Archived author: Tea • Posted: 2025-07-07T17:56:21.229000+00:00
Original source

Author: Neo2003 <none@none>
Date: 17 years ago (2.10.2008 23:23:55)
Commit hash: 9b1c0e006f20091f28f3f468cfcab1feb51286bd
Child: 2265aef9

[svn] * Proper SVN structure

Reply
Reply
rektbyfaith
Administrator
Find
0
07-07-2025, 05:56 PM
#4
Archived author: Tea • Posted: 2025-07-07T17:56:23.210000+00:00
Original source

commit 1
Reply
Reply
rektbyfaith
07-07-2025, 05:56 PM #4

Archived author: Tea • Posted: 2025-07-07T17:56:23.210000+00:00
Original source

commit 1

Reply
Reply
rektbyfaith
Administrator
Find
0
07-07-2025, 05:57 PM
#5
Archived author: robinsch • Posted: 2025-07-07T17:57:03.299000+00:00
Original source

well sounds like a pretty old bug to me then I mean sure I can just delete the entry from DB but just debugging this it seems to be just wrong.
Reply
Reply
rektbyfaith
07-07-2025, 05:57 PM #5

Archived author: robinsch • Posted: 2025-07-07T17:57:03.299000+00:00
Original source

well sounds like a pretty old bug to me then I mean sure I can just delete the entry from DB but just debugging this it seems to be just wrong.

Reply
Reply
rektbyfaith
Administrator
Find
0
07-07-2025, 05:58 PM
#6
Archived author: Tea • Posted: 2025-07-07T17:58:06.631000+00:00
Original source

that should use LootTemplates_Reference.GetLootFor
Reply
Reply
rektbyfaith
07-07-2025, 05:58 PM #6

Archived author: Tea • Posted: 2025-07-07T17:58:06.631000+00:00
Original source

that should use LootTemplates_Reference.GetLootFor

Reply
Reply
rektbyfaith
Administrator
Find
0
07-07-2025, 05:58 PM
#7
Archived author: Tea • Posted: 2025-07-07T17:58:54.148000+00:00
Original source

something like this
Reply
Reply
rektbyfaith
07-07-2025, 05:58 PM #7

Archived author: Tea • Posted: 2025-07-07T17:58:54.148000+00:00
Original source

something like this

Reply
Reply
rektbyfaith
Administrator
Find
0
07-07-2025, 05:59 PM
#8
Archived author: Tea • Posted: 2025-07-07T17:59:03.752000+00:00
Original source

```diff
diff --git a/src/server/game/Loot/LootMgr.cpp b/src/server/game/Loot/LootMgr.cpp
index 5c8b9b174c..25c23a7b18 100644
--- a/src/server/game/Loot/LootMgr.cpp
+++ b/src/server/game/Loot/LootMgr.cpp
@@ -622,10 +622,10 @@ bool LootTemplate::HasQuestDrop(LootTemplateMap const& store, uint8 groupId) con
LootStoreItem* item = *i;
if (item->reference > 0) // References
{
- LootTemplateMap::const_iterator Referenced = store.find(item->reference);
- if (Referenced == store.end())
+ LootTemplate const* Referenced = LootTemplates_Reference.GetLootFor(item->reference);
+ if (!Referenced)
continue; // Error message [should be] already printed at loading stage
- if (Referenced->second->HasQuestDrop(store, item->groupid))
+ if (Referenced->HasQuestDrop(store, item->groupid))
return true;
}
else if (item->needs_quest)
```
Reply
Reply
rektbyfaith
07-07-2025, 05:59 PM #8

Archived author: Tea • Posted: 2025-07-07T17:59:03.752000+00:00
Original source

```diff
diff --git a/src/server/game/Loot/LootMgr.cpp b/src/server/game/Loot/LootMgr.cpp
index 5c8b9b174c..25c23a7b18 100644
--- a/src/server/game/Loot/LootMgr.cpp
+++ b/src/server/game/Loot/LootMgr.cpp
@@ -622,10 +622,10 @@ bool LootTemplate::HasQuestDrop(LootTemplateMap const& store, uint8 groupId) con
LootStoreItem* item = *i;
if (item->reference > 0) // References
{
- LootTemplateMap::const_iterator Referenced = store.find(item->reference);
- if (Referenced == store.end())
+ LootTemplate const* Referenced = LootTemplates_Reference.GetLootFor(item->reference);
+ if (!Referenced)
continue; // Error message [should be] already printed at loading stage
- if (Referenced->second->HasQuestDrop(store, item->groupid))
+ if (Referenced->HasQuestDrop(store, item->groupid))
return true;
}
else if (item->needs_quest)
```

Reply
Reply
rektbyfaith
Administrator
Find
0
07-07-2025, 05:59 PM
#9
Archived author: robinsch • Posted: 2025-07-07T17:59:25.206000+00:00
Original source

and then remove store as arg i guess
Reply
Reply
rektbyfaith
07-07-2025, 05:59 PM #9

Archived author: robinsch • Posted: 2025-07-07T17:59:25.206000+00:00
Original source

and then remove store as arg i guess

Reply
Reply
rektbyfaith
Administrator
Find
0
07-07-2025, 05:59 PM
#10
Archived author: Tea • Posted: 2025-07-07T17:59:43.839000+00:00
Original source

y
Reply
Reply
rektbyfaith
07-07-2025, 05:59 PM #10

Archived author: Tea • Posted: 2025-07-07T17:59:43.839000+00:00
Original source

y

Reply
Reply
Pages (2): 1 2 Next
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)