[DiscordArchive] And are you sure that compromise won't break next time we implement a core mechanic properly ?
[DiscordArchive] And are you sure that compromise won't break next time we implement a core mechanic properly ?
Original source
And are you sure that compromise won't break next time we implement a core mechanic properly ?
rektbyfaith
07-01-2024, 12:21 AM #1Archived author: jackpoz • Posted: 2024-07-01T00:21:29.776000+00:00
Original source
And are you sure that compromise won't break next time we implement a core mechanic properly ?
Original source
Try to guess how many quests broke when we implemented gameobject spell casting, as everyone hackfixed that by making the targeted player cast the spell instead
rektbyfaith
07-01-2024, 12:22 AM #2Archived author: jackpoz • Posted: 2024-07-01T00:22:27.402000+00:00
Original source
Try to guess how many quests broke when we implemented gameobject spell casting, as everyone hackfixed that by making the targeted player cast the spell instead
Original source
Or when ppl implement new target types by reusing old ones and the spells end up targetting different stuff
rektbyfaith
07-01-2024, 12:23 AM #3Archived author: jackpoz • Posted: 2024-07-01T00:23:17.919000+00:00
Original source
Or when ppl implement new target types by reusing old ones and the spells end up targetting different stuff
Original source
It depends on how extensive the change is that you have made. But as I said, that's why I'm not sending a PR because it doesn't make sense, because such massive workarounds are rejected anyway.
Quests that cannot work due to factors such as core compatibility are deactivated, e.g. spells have to be scripted and I can't find alternative spells for them or rewrite them.
rektbyfaith
07-01-2024, 12:23 AM #4Archived author: Krutok • Posted: 2024-07-01T00:23:27.293000+00:00
Original source
It depends on how extensive the change is that you have made. But as I said, that's why I'm not sending a PR because it doesn't make sense, because such massive workarounds are rejected anyway.
Quests that cannot work due to factors such as core compatibility are deactivated, e.g. spells have to be scripted and I can't find alternative spells for them or rewrite them.
Original source
You can't really judge if the fix is good enough until you have discovered its bugs
rektbyfaith
07-01-2024, 12:23 AM #5Archived author: jackpoz • Posted: 2024-07-01T00:23:48.121000+00:00
Original source
You can't really judge if the fix is good enough until you have discovered its bugs
Original source
I don't get though, if hackfixing is so much faster and you already did that, what's left to do ? Is everything fixed ?
rektbyfaith
07-01-2024, 12:28 AM #6Archived author: jackpoz • Posted: 2024-07-01T00:28:58.909000+00:00
Original source
I don't get though, if hackfixing is so much faster and you already did that, what's left to do ? Is everything fixed ?
Original source
For this I create custom spells that are then cast differently. e.g. apply aura nearby must have a fixed NPC as the target. I copied the spell and then changed it so that it doesn't need a fixed NPC. So correcting the quest or anything else would be easy for me. Once the core has scripted the spell and is working as it should, the spell is simply replaced with the original. A matter of 1 minute.
So I do my workarounds so that I don't have to do much work to get them back to their original state.
Or an example quest: https://www.wowhead.com/wotlk/quest=1222...amberseeds I copied the original quest because you can't accept the quest. After I copied it, I simply replaced my quest with the original in the quest chain and you can now accept the quest from the bucket. There is also a bug report about this that hasn't been fixed.
In this case the player does not notice that it is a different quest ID as long as the original quest works.
rektbyfaith
07-01-2024, 12:32 AM #7Archived author: Krutok • Posted: 2024-07-01T00:32:36.807000+00:00
Original source
For this I create custom spells that are then cast differently. e.g. apply aura nearby must have a fixed NPC as the target. I copied the spell and then changed it so that it doesn't need a fixed NPC. So correcting the quest or anything else would be easy for me. Once the core has scripted the spell and is working as it should, the spell is simply replaced with the original. A matter of 1 minute.
So I do my workarounds so that I don't have to do much work to get them back to their original state.
Or an example quest: https://www.wowhead.com/wotlk/quest=1222...amberseeds I copied the original quest because you can't accept the quest. After I copied it, I simply replaced my quest with the original in the quest chain and you can now accept the quest from the bucket. There is also a bug report about this that hasn't been fixed.
In this case the player does not notice that it is a different quest ID as long as the original quest works.
Original source
Oh golly
rektbyfaith
07-01-2024, 12:33 AM #8Archived author: Bench • Posted: 2024-07-01T00:33:01.653000+00:00
Original source
Oh golly
Original source
Well at least you have a long term plan
rektbyfaith
07-01-2024, 12:33 AM #9Archived author: jackpoz • Posted: 2024-07-01T00:33:21.563000+00:00
Original source
Well at least you have a long term plan
Original source
But I don't get it why not to fix the original quest instead ♂️
rektbyfaith
07-01-2024, 12:35 AM #10Archived author: jackpoz • Posted: 2024-07-01T00:35:02.740000+00:00
Original source
But I don't get it why not to fix the original quest instead ♂️
1 Guest(s)
1 Guest(s)