[DiscordArchive] also, reviewing a PR is not really just a maintainers kind of thing. how many of those ppl sending a
[DiscordArchive] also, reviewing a PR is not really just a maintainers kind of thing. how many of those ppl sending a
Original source
also, reviewing a PR is not really just a maintainers kind of thing. how many of those ppl sending a PR test someone else PR ?
rektbyfaith
03-09-2024, 08:37 PM #1Archived author: jackpoz • Posted: 2024-03-09T20:37:26.874000+00:00
Original source
also, reviewing a PR is not really just a maintainers kind of thing. how many of those ppl sending a PR test someone else PR ?
Original source
No one does
rektbyfaith
03-09-2024, 08:37 PM #2Archived author: Foe • Posted: 2024-03-09T20:37:37.040000+00:00
Original source
No one does
Original source
then you have the ones who send PRs that don't even build
rektbyfaith
03-09-2024, 08:37 PM #3Archived author: jackpoz • Posted: 2024-03-09T20:37:57.187000+00:00
Original source
then you have the ones who send PRs that don't even build
Original source
or the ones who script a whole instance in 1 PR
rektbyfaith
03-09-2024, 08:38 PM #4Archived author: jackpoz • Posted: 2024-03-09T20:38:55.088000+00:00
Original source
or the ones who script a whole instance in 1 PR
Original source
and expect it to be blindly merged
rektbyfaith
03-09-2024, 08:39 PM #5Archived author: jackpoz • Posted: 2024-03-09T20:39:05.949000+00:00
Original source
and expect it to be blindly merged
Original source
we had a few PRs that "converted" packets to packet classes
rektbyfaith
03-09-2024, 08:40 PM #6Archived author: jackpoz • Posted: 2024-03-09T20:40:54.167000+00:00
Original source
we had a few PRs that "converted" packets to packet classes
Original source
literally broke perfectly working ingame features
rektbyfaith
03-09-2024, 08:41 PM #7Archived author: jackpoz • Posted: 2024-03-09T20:41:04.978000+00:00
Original source
literally broke perfectly working ingame features
Original source
Would it help to have different tiers of reviewers? Have some people willing to do the initial sanity check, some willing to check it meets TC standards, and someone else who only has to do the final sign-off on PRs the earlier stages think are acceptable.
I'm not sure if you have enough people for that, but it might help those with a deep knowledge of the application having to review nonsense PRs
rektbyfaith
03-09-2024, 08:50 PM #8Archived author: stoneharry • Posted: 2024-03-09T20:50:50.393000+00:00
Original source
Would it help to have different tiers of reviewers? Have some people willing to do the initial sanity check, some willing to check it meets TC standards, and someone else who only has to do the final sign-off on PRs the earlier stages think are acceptable.
I'm not sure if you have enough people for that, but it might help those with a deep knowledge of the application having to review nonsense PRs
Original source
Yeah, I think the amount of people would end up being the main problem
rektbyfaith
03-09-2024, 08:52 PM #9Archived author: Foe • Posted: 2024-03-09T20:52:39.412000+00:00
Original source
Yeah, I think the amount of people would end up being the main problem
Original source
For simple PR's it might be fine, but for the larger and more complex ones I can see the "lower" tiers falling off quickly
rektbyfaith
03-09-2024, 08:53 PM #10Archived author: Foe • Posted: 2024-03-09T20:53:05.257000+00:00
Original source
For simple PR's it might be fine, but for the larger and more complex ones I can see the "lower" tiers falling off quickly
1 Guest(s)
1 Guest(s)