[DiscordArchive] Doesn't ```MMapManager::GetNavMeshQuery``` needs a lock when inserting into ```mmap->navMeshQueries`
[DiscordArchive] Doesn't ```MMapManager::GetNavMeshQuery``` needs a lock when inserting into ```mmap->navMeshQueries`
Original source
https://github.com/TrinityCore/TrinityCo...or.cpp#L45
[Embed: TrinityCore/src/server/game/Movement/PathGenerator.cpp at 3.3.5 · T...]
TrinityCore Open Source MMO Framework (master = 10.2.0.52808, 3.3.5 = 3.3.5a.12340, wotlk_classic = 3.4.3.52237) - TrinityCore/TrinityCore
https://github.com/TrinityCore/TrinityCo...erator.cpp
rektbyfaith
01-17-2024, 08:36 PM #11Archived author: robinsch • Posted: 2024-01-17T20:36:26.989000+00:00
Original source
https://github.com/TrinityCore/TrinityCo...or.cpp#L45
[Embed: TrinityCore/src/server/game/Movement/PathGenerator.cpp at 3.3.5 · T...]
TrinityCore Open Source MMO Framework (master = 10.2.0.52808, 3.3.5 = 3.3.5a.12340, wotlk_classic = 3.4.3.52237) - TrinityCore/TrinityCore
https://github.com/TrinityCore/TrinityCo...erator.cpp
Original source
in case `navMeshQueries.find` fails, it will insert into `navMeshQueries`. This should be able to happen from multiple threads (instances)
rektbyfaith
01-17-2024, 08:38 PM #12Archived author: robinsch • Posted: 2024-01-17T20:38:25.202000+00:00
Original source
in case `navMeshQueries.find` fails, it will insert into `navMeshQueries`. This should be able to happen from multiple threads (instances)
Original source
oh i know why i got confused
rektbyfaith
01-17-2024, 08:38 PM #13Archived author: Tea • Posted: 2024-01-17T20:38:46.961000+00:00
Original source
oh i know why i got confused
Original source
i fixed this in master branch
rektbyfaith
01-17-2024, 08:38 PM #14Archived author: Tea • Posted: 2024-01-17T20:38:52.015000+00:00
Original source
i fixed this in master branch
Original source
oh nice
rektbyfaith
01-17-2024, 08:38 PM #15Archived author: robinsch • Posted: 2024-01-17T20:38:57.393000+00:00
Original source
oh nice
Original source
https://github.com/TrinityCore/TrinityCo...r.cpp#L349 no insert here
[Embed: TrinityCore/src/common/Collision/Management/MMapManager.cpp at mast...]
TrinityCore Open Source MMO Framework (master = 10.2.0.52808, 3.3.5 = 3.3.5a.12340, wotlk_classic = 3.4.3.52237) - TrinityCore/TrinityCore
https://github.com/TrinityCore/TrinityCo...anager.cpp
rektbyfaith
01-17-2024, 08:39 PM #16Archived author: Tea • Posted: 2024-01-17T20:39:11.428000+00:00
Original source
https://github.com/TrinityCore/TrinityCo...r.cpp#L349 no insert here
[Embed: TrinityCore/src/common/Collision/Management/MMapManager.cpp at mast...]
TrinityCore Open Source MMO Framework (master = 10.2.0.52808, 3.3.5 = 3.3.5a.12340, wotlk_classic = 3.4.3.52237) - TrinityCore/TrinityCore
https://github.com/TrinityCore/TrinityCo...anager.cpp
Original source
it all begins with this commit https://github.com/TrinityCore/TrinityCo...0c75ac0b38
[Embed: Core/Maps: Move terrain data handling out of Map class · TrinityCor...]
Partial port of cmangos/mangos-wotlk@ff5232c64809207b5fa59d62e9870f58a36b6f3f
https://github.com/TrinityCore/TrinityCo...0c75ac0b38
rektbyfaith
01-17-2024, 08:41 PM #17Archived author: Tea • Posted: 2024-01-17T20:41:26.526000+00:00
Original source
it all begins with this commit https://github.com/TrinityCore/TrinityCo...0c75ac0b38
[Embed: Core/Maps: Move terrain data handling out of Map class · TrinityCor...]
Partial port of cmangos/mangos-wotlk@ff5232c64809207b5fa59d62e9870f58a36b6f3f
https://github.com/TrinityCore/TrinityCo...0c75ac0b38
1 Guest(s)
1 Guest(s)