[DiscordArchive] Does anyone have a clue in the 3.3.5 source where the code to auto-flag people when in opposing fact
[DiscordArchive] Does anyone have a clue in the 3.3.5 source where the code to auto-flag people when in opposing fact
Archived author: Snowcraft • Posted: 2023-01-13T16:14:42.080000+00:00
Original source
So, TeamForRace isn't directly used, but what it sets does cause people to become PvP flagged in certain conditions.
![[Image: image.png?ex=690c20f8&is=690acf78&hm=155...4ce5079bd&]](https://cdn.discordapp.com/attachments/376457042392514560/1063491583762243745/image.png?ex=690c20f8&is=690acf78&hm=155fd871f604438a128ba3f3a253ed884327177ab6e9a4f64db2f3b4ce5079bd&)
Archived author: Snowcraft • Posted: 2023-01-13T16:15:52.353000+00:00
Original source
Actually, that might be partially wrong, but the point remains.
![[Image: image.png?ex=690c20f8&is=690acf78&hm=155...4ce5079bd&]](https://cdn.discordapp.com/attachments/376457042392514560/1063491583762243745/image.png?ex=690c20f8&is=690acf78&hm=155fd871f604438a128ba3f3a253ed884327177ab6e9a4f64db2f3b4ce5079bd&)
Archived author: Snowcraft • Posted: 2023-01-13T16:16:17.862000+00:00
Original source
If you're in a Hostile Area, which the Alliance and Horde capital cities are considered for the opposing team, you get flagged for PvP.
Archived author: Snowcraft • Posted: 2023-01-13T16:18:17.833000+00:00
Original source
Either way, the team should be dependent on what faction the character belongs to, not the language they speak.
Archived author: Snowcraft • Posted: 2023-01-13T16:18:47.071000+00:00
Original source
I think it just didn't get noticed because anyone who wants x-faction comms just sets universal language up, rather than trying to rejig the language system for their project like I am.
Archived author: Snowcraft • Posted: 2023-01-13T16:19:48.775000+00:00
Original source
Like, it's a non-issue kinda issue. Wrong technically, but doesn't really impact anything unless you modify shit.
Archived author: Snowcraft • Posted: 2023-01-13T16:20:01.569000+00:00
Original source
Like I tried to do.
Archived author: Jinnai • Posted: 2023-01-13T16:20:16.737000+00:00
Original source
```cpp
void Player::SetFactionForRace(uint8 race)
{
m_team = TeamForRace(race);
ChrRacesEntry const* rEntry = sChrRacesStore.LookupEntry(race);
SetFaction(rEntry ? rEntry->FactionID : 0);
}
```
as far as i undertand it, this is how faction is set
Archived author: Jinnai • Posted: 2023-01-13T16:22:05.464000+00:00
Original source
the function you previously mentioned, team for race, does not handle anything related to flagging or pvp
Archived author: Snowcraft • Posted: 2023-01-13T16:22:27.303000+00:00
Original source
Well, I'm testing a quick rebuild now, so I'll find out shortly if this is working how I think it does.