[DiscordArchive] Can it be additional affected by increased client loading time due to massive amount of interface ad
[DiscordArchive] Can it be additional affected by increased client loading time due to massive amount of interface ad
Original source
Can it be additional affected by increased client loading time due to massive amount of interface addons?
rektbyfaith
04-14-2022, 08:02 AM #1Archived author: Jinnai • Posted: 2022-04-14T08:02:12.393000+00:00
Original source
Can it be additional affected by increased client loading time due to massive amount of interface addons?
Original source
Not your fix, the old but
rektbyfaith
04-14-2022, 08:03 AM #2Archived author: Jinnai • Posted: 2022-04-14T08:03:01.285000+00:00
Original source
Not your fix, the old but
Original source
*bug
rektbyfaith
04-14-2022, 08:03 AM #3Archived author: Jinnai • Posted: 2022-04-14T08:03:04.980000+00:00
Original source
*bug
Original source
Hmmm, I'm unsure honestly the full details of the bug in the client itself. But it seems to happen to some objects that happen to have their creates sent to the client during Player::LoadFromDB which unfortunately is written in a way that triggers some visibility/notifier updates before the player is actually in the world.
rektbyfaith
04-14-2022, 08:11 AM #4Archived author: HelloKitty • Posted: 2022-04-14T08:11:02.565000+00:00
Original source
Hmmm, I'm unsure honestly the full details of the bug in the client itself. But it seems to happen to some objects that happen to have their creates sent to the client during Player::LoadFromDB which unfortunately is written in a way that triggers some visibility/notifier updates before the player is actually in the world.
Original source
it seems to only happen on some graphics cards
rektbyfaith
04-14-2022, 08:21 AM #5Archived author: <o> • Posted: 2022-04-14T08:21:19.080000+00:00
Original source
it seems to only happen on some graphics cards
Original source
we were able to reproduce it on multiple setups that had radeon cards, but much more difficult if at all with any other. There might be multiple issues combined that causes this. I haven't been able to follow it closely, but i believe reports for it only started a few years back
rektbyfaith
04-14-2022, 08:25 AM #6Archived author: <o> • Posted: 2022-04-14T08:25:13.673000+00:00
Original source
we were able to reproduce it on multiple setups that had radeon cards, but much more difficult if at all with any other. There might be multiple issues combined that causes this. I haven't been able to follow it closely, but i believe reports for it only started a few years back
Original source
i'll try grabbing one of our users with this problem to try out your fix
rektbyfaith
04-14-2022, 08:26 AM #7Archived author: <o> • Posted: 2022-04-14T08:26:30.231000+00:00
Original source
i'll try grabbing one of our users with this problem to try out your fix
Original source
Okie dokie, let me know how it goes! I strongly believe it's related to this issue of out of order packets I reported years ago <https://github.com/TrinityCore/TrinityCore/issues/24846>. This PR is very "general" and I am worried it may introduce unknown regressions. On my fork I have identified the cases where the function is called outside of the world such as in Player::LoadFromDB setting Drunk value on Player. Ignoring calls to those specific uses outside of the world is likely better for a live server, less risky. But this PR is a possible general solution I think, but could impact a lot of stuff which is always worrying!
rektbyfaith
04-14-2022, 08:29 AM #8Archived author: HelloKitty • Posted: 2022-04-14T08:29:38.778000+00:00
Original source
Okie dokie, let me know how it goes! I strongly believe it's related to this issue of out of order packets I reported years ago <https://github.com/TrinityCore/TrinityCore/issues/24846>. This PR is very "general" and I am worried it may introduce unknown regressions. On my fork I have identified the cases where the function is called outside of the world such as in Player::LoadFromDB setting Drunk value on Player. Ignoring calls to those specific uses outside of the world is likely better for a live server, less risky. But this PR is a possible general solution I think, but could impact a lot of stuff which is always worrying!
Original source
yeah we'll just check if it does resolve the model issue itself, then we can look into the solution more closely
rektbyfaith
04-14-2022, 08:30 AM #9Archived author: <o> • Posted: 2022-04-14T08:30:20.054000+00:00
Original source
yeah we'll just check if it does resolve the model issue itself, then we can look into the solution more closely
1 Guest(s)
1 Guest(s)