Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] I’m still rather confused.

[DiscordArchive] I’m still rather confused.

[DiscordArchive] I’m still rather confused.

rektbyfaith
Administrator
0
12-10-2020, 08:23 PM
#1
Archived author: Kaneit • Posted: 2020-12-10T20:23:01.191000+00:00
Original source

I’m still rather confused.

https://github.com/TrinityCore/TrinityCo...-742559004

Did it get fixed?
[Embed: Attempt to fix crashes of chat commands added last summer by jackpo...]
Changes proposed:

Fix crashes

Target branch(es): 3.3.5/master

3.3.5
master

Issues addressed:
Closes #25692
Tests performed:
None
Known issues and TODO list: (add/remove lines as needed)

Fix...
https://github.com/TrinityCore/TrinityCore/pull/25698
rektbyfaith
12-10-2020, 08:23 PM #1

Archived author: Kaneit • Posted: 2020-12-10T20:23:01.191000+00:00
Original source

I’m still rather confused.

https://github.com/TrinityCore/TrinityCo...-742559004

Did it get fixed?
[Embed: Attempt to fix crashes of chat commands added last summer by jackpo...]
Changes proposed:

Fix crashes

Target branch(es): 3.3.5/master

3.3.5
master

Issues addressed:
Closes #25692
Tests performed:
None
Known issues and TODO list: (add/remove lines as needed)

Fix...
https://github.com/TrinityCore/TrinityCore/pull/25698

rektbyfaith
Administrator
0
12-10-2020, 08:24 PM
#2
Archived author: MaxtorCoder • Posted: 2020-12-10T20:24:53.095000+00:00
Original source

No
rektbyfaith
12-10-2020, 08:24 PM #2

Archived author: MaxtorCoder • Posted: 2020-12-10T20:24:53.095000+00:00
Original source

No

rektbyfaith
Administrator
0
12-10-2020, 08:25 PM
#3
Archived author: MaxtorCoder • Posted: 2020-12-10T20:25:01.544000+00:00
Original source

Read what's said in the PR message.
rektbyfaith
12-10-2020, 08:25 PM #3

Archived author: MaxtorCoder • Posted: 2020-12-10T20:25:01.544000+00:00
Original source

Read what's said in the PR message.

rektbyfaith
Administrator
0
12-10-2020, 08:25 PM
#4
Archived author: Kaneit • Posted: 2020-12-10T20:25:09.972000+00:00
Original source

You probably won’t get support here as it’s nothing to do with trinitycore.

FusionCMS has been obsolete for a long time now and still poses a threat to security.
rektbyfaith
12-10-2020, 08:25 PM #4

Archived author: Kaneit • Posted: 2020-12-10T20:25:09.972000+00:00
Original source

You probably won’t get support here as it’s nothing to do with trinitycore.

FusionCMS has been obsolete for a long time now and still poses a threat to security.

rektbyfaith
Administrator
0
12-10-2020, 08:25 PM
#5
Archived author: Kaneit • Posted: 2020-12-10T20:25:33.576000+00:00
Original source

That’s what I couldn’t understand
rektbyfaith
12-10-2020, 08:25 PM #5

Archived author: Kaneit • Posted: 2020-12-10T20:25:33.576000+00:00
Original source

That’s what I couldn’t understand

rektbyfaith
Administrator
0
12-10-2020, 08:25 PM
#6
Archived author: MaxtorCoder • Posted: 2020-12-10T20:25:47.669000+00:00
Original source

It got closed, not merged.
rektbyfaith
12-10-2020, 08:25 PM #6

Archived author: MaxtorCoder • Posted: 2020-12-10T20:25:47.669000+00:00
Original source

It got closed, not merged.

rektbyfaith
Administrator
0
12-10-2020, 08:29 PM
#7
Archived author: M'Dic • Posted: 2020-12-10T20:29:04.299000+00:00
Original source

It wasnt a fix at all. It was suppressing it. Making it fail silently
rektbyfaith
12-10-2020, 08:29 PM #7

Archived author: M'Dic • Posted: 2020-12-10T20:29:04.299000+00:00
Original source

It wasnt a fix at all. It was suppressing it. Making it fail silently

rektbyfaith
Administrator
0
12-10-2020, 08:29 PM
#8
Archived author: Kaneit • Posted: 2020-12-10T20:29:13.633000+00:00
Original source

I thought a commit got released I did see a Chathandler change and release but I’m unsure as to what it resolves.
I’m still trying to learn and understand all of this stuff
rektbyfaith
12-10-2020, 08:29 PM #8

Archived author: Kaneit • Posted: 2020-12-10T20:29:13.633000+00:00
Original source

I thought a commit got released I did see a Chathandler change and release but I’m unsure as to what it resolves.
I’m still trying to learn and understand all of this stuff

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)