[DiscordArchive] or is AC Ashamane?
[DiscordArchive] or is AC Ashamane?
Original source
my issue is that people arent using git commit --author
rektbyfaith
01-18-2022, 07:52 PM #11Archived author: Tea • Posted: 2022-01-18T19:52:30.342000+00:00
Original source
my issue is that people arent using git commit --author
Original source
that i would be more then happy to have addressed
rektbyfaith
01-18-2022, 07:52 PM #12Archived author: M'Dic • Posted: 2022-01-18T19:52:52.194000+00:00
Original source
that i would be more then happy to have addressed
Original source
or that github specific line
rektbyfaith
01-18-2022, 07:52 PM #13Archived author: Tea • Posted: 2022-01-18T19:52:54.749000+00:00
Original source
or that github specific line
Original source
i can only really speak for my own commits that were cherry picked, i do include original line and pr that was picked on my end. however, if what i done wasnt visible enough on what i did, do let me know.
rektbyfaith
01-18-2022, 07:53 PM #14Archived author: M'Dic • Posted: 2022-01-18T19:53:56.901000+00:00
Original source
i can only really speak for my own commits that were cherry picked, i do include original line and pr that was picked on my end. however, if what i done wasnt visible enough on what i did, do let me know.
Original source
but like i said, we had some issues with people pretty much doing cherrypicks for bounties just to find out later the cherrypicks didnt work, or only partially worked. but that was before my time as a azerothcore dev
rektbyfaith
01-18-2022, 07:55 PM #15Archived author: M'Dic • Posted: 2022-01-18T19:55:10.291000+00:00
Original source
but like i said, we had some issues with people pretty much doing cherrypicks for bounties just to find out later the cherrypicks didnt work, or only partially worked. but that was before my time as a azerothcore dev
Original source
you also never used `--author`
rektbyfaith
01-18-2022, 07:55 PM #16Archived author: ModoX • Posted: 2022-01-18T19:55:42.325000+00:00
Original source
you also never used `--author`
Original source
but even then i cringed pretty hard reading that person's notes on the prs. amazed that actually happened
rektbyfaith
01-18-2022, 07:55 PM #17Archived author: M'Dic • Posted: 2022-01-18T19:55:43.171000+00:00
Original source
but even then i cringed pretty hard reading that person's notes on the prs. amazed that actually happened
Original source
how should i prep that then on the PR. im still pretty minimal with git
rektbyfaith
01-18-2022, 07:56 PM #18Archived author: M'Dic • Posted: 2022-01-18T19:56:20.973000+00:00
Original source
how should i prep that then on the PR. im still pretty minimal with git
Original source
https://github.com/azerothcore/azerothco.../pull/8927
[Embed: ADD (Core) Wp table add in orientation and delay collumn TC Cherryp...]
ADD (Core) Wp table add in orientation and delay collumn
TC Cherry pick of TrinityCore/TrinityCore@4b7d19c
Changes Proposed:
adds in the orientation and delay to the waypoints table in the world.
...
https://github.com/azerothcore/azerothco.../pull/8927
rektbyfaith
01-18-2022, 07:57 PM #19Archived author: M'Dic • Posted: 2022-01-18T19:57:08.773000+00:00
Original source
https://github.com/azerothcore/azerothco.../pull/8927
[Embed: ADD (Core) Wp table add in orientation and delay collumn TC Cherryp...]
ADD (Core) Wp table add in orientation and delay collumn
TC Cherry pick of TrinityCore/TrinityCore@4b7d19c
Changes Proposed:
adds in the orientation and delay to the waypoints table in the world.
...
https://github.com/azerothcore/azerothco.../pull/8927
Original source
i guess best example would be that.
rektbyfaith
01-18-2022, 07:57 PM #20Archived author: M'Dic • Posted: 2022-01-18T19:57:15.579000+00:00
Original source
i guess best example would be that.
1 Guest(s)
1 Guest(s)