[DiscordArchive] Some projects like to accept every single PR no matter what, which means their contributors are lear
[DiscordArchive] Some projects like to accept every single PR no matter what, which means their contributors are lear
Original source
Some projects like to accept every single PR no matter what, which means their contributors are learning nothing because noone tells them what should be changed.
Which teacher is best, the one that gives 10/10 to everyone, or the one that gives 2/10 to everyone ? Could it be somewhere in the middle, doing an objective review and stating the mistakes so that one can learn ?
rektbyfaith
08-29-2025, 06:53 PM #1Archived author: jackpoz • Posted: 2025-08-29T18:53:04.242000+00:00
Original source
Some projects like to accept every single PR no matter what, which means their contributors are learning nothing because noone tells them what should be changed.
Which teacher is best, the one that gives 10/10 to everyone, or the one that gives 2/10 to everyone ? Could it be somewhere in the middle, doing an objective review and stating the mistakes so that one can learn ?
Original source
If you are copying from AC, you are stealing their code and breaking their license, unless you state in every PR that you copied code from them, which would then require also to include them in the AUTHORS file and release their code under their license
rektbyfaith
08-29-2025, 06:54 PM #2Archived author: jackpoz • Posted: 2025-08-29T18:54:30.888000+00:00
Original source
If you are copying from AC, you are stealing their code and breaking their license, unless you state in every PR that you copied code from them, which would then require also to include them in the AUTHORS file and release their code under their license
Original source
We don't like code stolen from other projects without giving any proper credit or with incompatible licenses
rektbyfaith
08-29-2025, 06:55 PM #3Archived author: jackpoz • Posted: 2025-08-29T18:55:09.723000+00:00
Original source
We don't like code stolen from other projects without giving any proper credit or with incompatible licenses
Original source
In any case, getting the maintainers of a project against you doesn't really improve the chances of getting your code reviewed more than other's code
rektbyfaith
08-29-2025, 06:56 PM #4Archived author: jackpoz • Posted: 2025-08-29T18:56:04.336000+00:00
Original source
In any case, getting the maintainers of a project against you doesn't really improve the chances of getting your code reviewed more than other's code
Original source
You've implemented this fix https://github.com/Thor1423/woltk/pull/1 I copied it from AC and it will remain in TC
rektbyfaith
08-29-2025, 06:56 PM #5Archived author: Crane • Posted: 2025-08-29T18:56:52.017000+00:00
Original source
You've implemented this fix https://github.com/Thor1423/woltk/pull/1 I copied it from AC and it will remain in TC
Original source
There are 105 PRs atm, I'd rather review the ones from contributors interested in going through the PR review process than the ones just rejecting any requested change
rektbyfaith
08-29-2025, 06:57 PM #6Archived author: jackpoz • Posted: 2025-08-29T18:57:18.011000+00:00
Original source
There are 105 PRs atm, I'd rather review the ones from contributors interested in going through the PR review process than the ones just rejecting any requested change
Original source
got a link for the PR on TC and AC ?
rektbyfaith
08-29-2025, 06:58 PM #7Archived author: jackpoz • Posted: 2025-08-29T18:58:22.732000+00:00
Original source
got a link for the PR on TC and AC ?
Original source
The PR comes from my repo and was included when I submitted the PR together with the one quest in Zuldrak
rektbyfaith
08-29-2025, 07:00 PM #8Archived author: Crane • Posted: 2025-08-29T19:00:14.897000+00:00
Original source
The PR comes from my repo and was included when I submitted the PR together with the one quest in Zuldrak
Original source
I had done a PR for the NPC Servant of Drakuru
rektbyfaith
08-29-2025, 07:01 PM #9Archived author: Crane • Posted: 2025-08-29T19:01:19.903000+00:00
Original source
I had done a PR for the NPC Servant of Drakuru
Original source
https://github.com/azerothcore/azerothco...ull/22302/ this probably
rektbyfaith
08-29-2025, 07:02 PM #10Archived author: Jinnai • Posted: 2025-08-29T19:02:47.083000+00:00
Original source
https://github.com/azerothcore/azerothco...ull/22302/ this probably
1 Guest(s)
1 Guest(s)